Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 1311683002: Clear m_previousActiveInterpolationsForAnimations in maybeApplyPendingUpdate() (Closed)

Created:
5 years, 4 months ago by haraken
Modified:
5 years, 4 months ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, Eric Willigers, rjwright, shans
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Clear m_previousActiveInterpolationsForAnimations in maybeApplyPendingUpdate() This is a performance-optimization CL for oilpan builds. In oilpan, it is important to explicitly clear on-heap collections in order not to leave unnecessary garbage on the oilpan's heap. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201053

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M Source/core/animation/css/CSSAnimations.cpp View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
haraken
PTAL I understand this is a nasty change. I think oilpan should have an ability ...
5 years, 4 months ago (2015-08-24 03:32:26 UTC) #2
alancutter (OOO until 2018)
lgtm, please add a comment here describing the Oilpan performance gain.
5 years, 4 months ago (2015-08-24 06:18:43 UTC) #3
alancutter (OOO until 2018)
Also for the record please reply with any performance numbers you might have that lead ...
5 years, 4 months ago (2015-08-24 06:20:43 UTC) #4
haraken
On 2015/08/24 06:20:43, alancutter wrote: > Also for the record please reply with any performance ...
5 years, 4 months ago (2015-08-24 06:53:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311683002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311683002/1
5 years, 4 months ago (2015-08-24 06:53:40 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/102951)
5 years, 4 months ago (2015-08-24 08:21:50 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311683002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311683002/1
5 years, 4 months ago (2015-08-24 08:23:34 UTC) #12
commit-bot: I haz the power
5 years, 4 months ago (2015-08-24 09:09:48 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201053

Powered by Google App Engine
This is Rietveld 408576698