Remove transparency clip, use 'bound' in CompositingRecorder instead.

Remove transparency clip, use 'bound' in CompositingRecorder instead.

The purpose of the transparency clip is to give Skia raster hints so that
a transparent layer can be sized according to the bounding box of contents
being composited. The clip itself should be no-op, but will actually cause
anti-alias artifact for transformed contents.

Removing the transparency clip and use compositing bound will allow Skia
to take account of anti-aliasing to properly size the transparent layer.

BUG=524859
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201202

[trchen, 2015-08-25 22:15:32]

trchen@chromium.org changed reviewers:
+ pdr@chromium.org

[trchen, 2015-08-25 22:15:33]

Haven't updated TestExpectation yet. Collecting results from trybots.

You can observe noticeable quality improvement for rotated borders in
transforms/2d/hindi-rotated-diffs.html.

[pdr., 2015-08-25 23:16:45]

On 2015/08/25 at 22:15:33, trchen wrote:
> Haven't updated TestExpectation yet. Collecting results from trybots.
> 
> You can observe noticeable quality improvement for rotated borders in
transforms/2d/hindi-rotated-diffs.html.

I like it!

Just waiting for compile + test results before lg'ing.

[pdr., 2015-08-26 03:05:14]

LGTM with test expectations updated.

https://codereview.chromium.org/1311633004/diff/1/Source/core/paint/Deprecate...
File Source/core/paint/DeprecatedPaintLayerPainter.cpp (right):

https://codereview.chromium.org/1311633004/diff/1/Source/core/paint/Deprecate...
Source/core/paint/DeprecatedPaintLayerPainter.cpp:220: FloatRect
compositingBound = FloatRect(m_paintLayer.paintingExtent(paintingInfo.rootLayer,
paintingInfo.paintDirtyRect, paintingInfo.globalPaintFlags()));
Nit: compositingBounds

[trchen, 2015-08-26 03:46:06]

The CQ bit was checked by trchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-08-26 03:46:12]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1311633004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1311633004/20001

[commit-bot: I haz the power, 2015-08-26 04:00:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-26 04:00:45]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)
  cast_shell_android on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_andr...)

[trchen, 2015-08-26 04:32:56]

The CQ bit was checked by trchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-08-26 04:33:15]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1311633004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1311633004/40001

[commit-bot: I haz the power, 2015-08-26 05:50:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-26 05:50:23]

Dry run: This issue passed the CQ dry run.

[trchen, 2015-08-26 06:04:04]

The CQ bit was checked by trchen@chromium.org

[trchen, 2015-08-26 06:04:05]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/1311633004/#ps40001
(title: "fix debug build")

[commit-bot: I haz the power, 2015-08-26 06:04:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1311633004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1311633004/40001

[commit-bot: I haz the power, 2015-08-26 06:08:37]

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201202