Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 131163007: release the scanline textures in GrRectBlurEffect (Closed)

Created:
6 years, 10 months ago by humper
Modified:
6 years, 10 months ago
Reviewers:
robertphillips
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

release the scanline textures in GrRectBlurEffect BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=13260

Patch Set 1 #

Patch Set 2 : Whoops, unref >> release #

Patch Set 3 : use autounref, and clean up more tidy after CreateScanlineTextures in the event that creating the v… #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M src/effects/SkBlurMaskFilter.cpp View 1 2 2 chunks +5 lines, -3 lines 2 comments Download

Messages

Total messages: 7 (0 generated)
robertphillips
lgtm
6 years, 10 months ago (2014-01-31 13:22:00 UTC) #1
humper
The CQ bit was checked by humper@google.com
6 years, 10 months ago (2014-01-31 13:27:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/humper@google.com/131163007/50001
6 years, 10 months ago (2014-01-31 13:27:11 UTC) #3
robertphillips
https://codereview.chromium.org/131163007/diff/50001/src/effects/SkBlurMaskFilter.cpp File src/effects/SkBlurMaskFilter.cpp (right): https://codereview.chromium.org/131163007/diff/50001/src/effects/SkBlurMaskFilter.cpp#newcode534 src/effects/SkBlurMaskFilter.cpp:534: &horizontalScanline, &verticalScanline); Won't this potentially cause a problem if ...
6 years, 10 months ago (2014-01-31 13:33:10 UTC) #4
humper
https://codereview.chromium.org/131163007/diff/50001/src/effects/SkBlurMaskFilter.cpp File src/effects/SkBlurMaskFilter.cpp (right): https://codereview.chromium.org/131163007/diff/50001/src/effects/SkBlurMaskFilter.cpp#newcode534 src/effects/SkBlurMaskFilter.cpp:534: &horizontalScanline, &verticalScanline); On 2014/01/31 13:33:10, robertphillips wrote: > Won't ...
6 years, 10 months ago (2014-01-31 13:51:17 UTC) #5
commit-bot: I haz the power
Change committed as 13260
6 years, 10 months ago (2014-01-31 14:01:06 UTC) #6
commit-bot: I haz the power
6 years, 10 months ago (2014-01-31 14:01:50 UTC) #7
Message was sent while issue was closed. 
CQ bit was unchecked on CL. Ignoring.

Powered by Google App Engine
This is Rietveld 408576698