Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1311623002: Add more components_unittests to GN build (Closed)

Created:
5 years, 4 months ago by brettw
Modified:
5 years, 4 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, tim+watch_chromium.org, zea+watch_chromium.org, maxbogue+watch_chromium.org, jam, pvalenzuela+watch_chromium.org, darin-cc_chromium.org, oshima+watch_chromium.org, plaree+watch_chromium.org, wifiprefetch-reviews_google.com
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add more components_unittests to GN build This adds tests for: url matcher, precache, sync driver, serialization, proxy config, leveldb proto, error page, storage monitor, search provider logos, translate, json schema, guest view, dom distiller, network hints. CQ_EXTRA_TRYBOTS=tryserver.chromium.mac:mac_chromium_gn_rel TBR=dpranke@chromium.org Reland of issue 1303703004. TBR=dpranke@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/817fec0d4f038f90cae45ed78fe71f22336c3c4a

Patch Set 1 : Original patch #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+309 lines, -71 lines) Patch
M BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M build/gn_migration.gypi View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/BUILD.gn View 1 chunk +3 lines, -3 lines 0 comments Download
M components/BUILD.gn View 7 chunks +21 lines, -2 lines 0 comments Download
M components/components_tests.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M components/dom_distiller/content/BUILD.gn View 1 chunk +57 lines, -45 lines 0 comments Download
M components/dom_distiller/core/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/error_page/renderer/BUILD.gn View 2 chunks +12 lines, -1 line 0 comments Download
M components/guest_view/browser/BUILD.gn View 1 chunk +12 lines, -1 line 0 comments Download
M components/json_schema/BUILD.gn View 2 chunks +14 lines, -1 line 0 comments Download
M components/leveldb_proto/BUILD.gn View 1 chunk +13 lines, -1 line 0 comments Download
M components/metrics/BUILD.gn View 1 chunk +5 lines, -0 lines 0 comments Download
M components/network_hints/renderer/BUILD.gn View 1 chunk +12 lines, -0 lines 0 comments Download
M components/precache/content/BUILD.gn View 2 chunks +13 lines, -1 line 0 comments Download
M components/precache/core/BUILD.gn View 2 chunks +16 lines, -1 line 0 comments Download
M components/proxy_config/BUILD.gn View 1 chunk +12 lines, -0 lines 0 comments Download
M components/search_provider_logos/BUILD.gn View 2 chunks +19 lines, -3 lines 0 comments Download
M components/storage_monitor/BUILD.gn View 1 3 chunks +36 lines, -5 lines 0 comments Download
M components/sync_driver/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/translate/core/browser/BUILD.gn View 1 chunk +15 lines, -0 lines 0 comments Download
M components/translate/core/common/BUILD.gn View 1 chunk +12 lines, -0 lines 0 comments Download
M components/translate/core/language_detection/BUILD.gn View 2 chunks +16 lines, -4 lines 0 comments Download
M components/url_matcher/BUILD.gn View 2 chunks +16 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
brettw
5 years, 4 months ago (2015-08-22 18:29:44 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311623002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311623002/20001
5 years, 4 months ago (2015-08-22 18:29:45 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/94390)
5 years, 4 months ago (2015-08-22 20:03:53 UTC) #5
brettw
5 years, 4 months ago (2015-08-22 20:39:56 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
817fec0d4f038f90cae45ed78fe71f22336c3c4a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698