Issue 1311613005: Add ParameterMirror.isInitializingFormal to dart:mirrors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1311613005: Add ParameterMirror.isInitializingFormal to dart:mirrors

Created:
5 years, 3 months ago by Adam Stark

Modified:
5 years, 3 months ago

Reviewers:

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Add ParameterMirror.isInitializingFormal to dart:mirrors * resolves dart-lang/sdk#16094 * Added test for above. * I'm not a Googler so I'm not sure who to add to reviewers. BUG=https://github.com/dart-lang/sdk/issues/16094

Patch Set 1 #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+65 lines, -8 lines)			Patch
M	pkg/compiler/lib/src/js_emitter/full_emitter/container_builder.dart	View	3 chunks	+11 lines, -2 lines	0 comments	Download
M	pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	pkg/compiler/lib/src/js_emitter/full_emitter/setup_program_builder.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/lib/mirrors.cc	View	4 chunks	+6 lines, -1 line	0 comments	Download
M	runtime/lib/mirrors_impl.dart	View	3 chunks	+4 lines, -1 line	0 comments	Download
M	runtime/vm/parser.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/parser.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	sdk/lib/_internal/js_runtime/lib/js_helper.dart	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	sdk/lib/_internal/js_runtime/lib/js_mirrors.dart	View	5 chunks	+10 lines, -1 line	0 comments	Download
M	sdk/lib/mirrors/mirrors.dart	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	tests/lib/mirrors/parameter_test.dart	View	3 chunks	+11 lines, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Adam Stark

5 years, 3 months ago (2015-08-29 22:05:48 UTC) #1

Please take a look at your convenience. I think the name isInitializingFormal is
overly abstruse, but it was already in js_mirrors.dart that way...

Expand Messages | Collapse Messages