Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 1311613002: Revert of Update mojo sdk to rev c02a28868825edfa57ab77947b8cb15e741c5598 (Closed)

Created:
5 years, 4 months ago by yosin_UTC9
Modified:
5 years, 4 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, feature-media-reviews_chromium.org, extensions-reviews_chromium.org, qsr+mojo_chromium.org, Aaron Boodman, posciak+watch_chromium.org, ben+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, mcasas+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, media-router+watch_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, chromium-apps-reviews_chromium.org, darin (slow to review), wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Update mojo sdk to rev c02a28868825edfa57ab77947b8cb15e741c5598 (patchset #3 id:120001 of https://codereview.chromium.org/1296453004/ ) Reason for revert: Compilation error by missing include file: ../../content/renderer/usb/web_usb_client_impl.cc -o obj/content/renderer/renderer/web_usb_client_impl.o In file included from ../../content/renderer/usb/web_usb_client_impl.cc:14: ../../content/renderer/usb/web_usb_device_impl.h:17:10: fatal error: 'third_party/mojo/src/mojo/public/cpp/bindings/error_handler.h' file not found #include "third_party/mojo/src/mojo/public/cpp/bindings/error_handler.h" FAILED: /mnt/data/b/build/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/content/renderer/renderer/web_usb_client_impl.o.d -DV8_DEPRECATION_WARNINGS -DCLD_VERSION=2 -DENABLE_MDNS=1 -DENABLE_NOTIFICATIONS -DENABLE_PEPPER_CDMS -DENABLE_PLUGINS=1 -DENABLE_PRINTING=1 -DENABLE_BASIC_PRINTING=1 -DENABLE_PRINT_PREVIEW=1 -DENABLE_SPELLCHECK=1 -DDONT_EMBED_BUILD_METADATA -DUSE_UDEV -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_ASH=1 -DUSE_AURA=1 -DUSE_PANGO=1 -DUSE_CAIRO=1 -DUSE_CLIPBOARD_AURAX11=1 -DUSE_DEFAULT_RENDER_THEME=1 -DUSE_GLIB=1 -DUSE_OPENSSL=1 -DUSE_NSS_CERTS=1 -DUSE_X11=1 -DENABLE_WEBRTC=1 -DENABLE_EXTENSIONS=1 -DENABLE_CONFIGURATION_POLICY -DENABLE_TASK_MANAGER=1 -DENABLE_THEMES=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_APP_LIST=1 -DENABLE_SETTINGS_APP=1 -DENABLE_SUPERVISED_USERS=1 -DENABLE_SERVICE_DISCOVERY=1 -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_GOOGLE_NOW=1 -DENABLE_ONE_CLICK_SIGNIN -DENABLE_HIDPI=1 -DENABLE_TOPCHROME_MD=1 -DV8_USE_EXTERNAL_STARTUP_DATA -DENABLE_BACKGROUND=1 -DENABLE_PRE_SYNC_BACKUP -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DSAFE_BROWSING_SERVICE -DCHROMIUM_BUILD -DENABLE_MEDIA_ROUTER=1 -DFIELDTRIAL_TESTING_ENABLED -DCR_CLANG_REVISION=245402-1 -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DCOMPONENT_BUILD -D_DEBUG -DDYNAMIC_ANNOTATIONS_ENABLED=1 -DWTF_USE_DYNAMIC_ANNOTATIONS=1 -D_GLIBCXX_DEBUG=1 -DCONTENT_IMPLEMENTATION -DBORINGSSL_SHARED_LIBRARY -DGL_GLEXT_PROTOTYPES -DSK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS -DSKIA_DLL -DGR_GL_IGNORE_ES3_MSAA=0 -DSK_SUPPORT_GPU=1 -DGTEST_HAS_POSIX_RE=0 -DGTEST_LANG_CXX11=0 -DGTEST_HAS_RTTI=0 -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DUSE_LIBJPEG_TURBO=1 -DCHROME_PNG_WRITE_SUPPORT -DPNG_USER_CONFIG -DV8_SHARED -DUSING_V8_SHARED -DMOJO_USE_SYSTEM_IMPL -D_DEBUG -DFEATURE_ENABLE_SSL -DFEATURE_ENABLE_VOICEMAIL -DEXPAT_RELATIVE_PATH -DGTEST_RELATIVE_PATH -DNO_MAIN_THREAD_WRAPPING -DNO_SOUND_SYSTEM -DLINUX -DWEBRTC_LINUX -DWEBRTC_POSIX -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DPROTOBUF_USE_DLLS -DMESA_EGL_NO_X11_HEADERS -DWEBRTC_CHROMIUM_BUILD -DWEBRTC_POSIX -DWEBRTC_LINUX -I../.. -Igen -I/usr/include/nss -I/usr/include/nspr -I../../third_party/boringssl/src/include -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I../../third_party/khronos -I../../gpu -I../../skia/config -I../../skia/ext -I../../third_party/skia/include/c -I../../third_party/skia/include/config -I../../third_party/skia/include/core -I../../third_party/skia/include/effects -I../../third_party/skia/include/images -I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops -I../../third_party/skia/include/pdf -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports -I../../third_party/skia/include/utils -I../../third_party/skia/include/gpu -I../../third_party/skia/src/gpu -I../../third_party/libwebp -I../../testing/gtest/include -I../../third_party/WebKit -I../../third_party/icu/source/common -I../../third_party/icu/source/i18n -I../../third_party/npapi -I../../third_party/npapi/bindings -I../../third_party/libjpeg_turbo -I../../third_party/iccjpeg -I../../third_party/libpng -I../../third_party/zlib -I../../third_party/ots/include -I../../third_party/qcms/src -I../../v8/include -I../../third_party/mojo/src -Igen/third_party/mojo/src -I../../third_party/webrtc/overrides -I../../third_party/libjingle/overrides -I../../third_party/libjingle/source -I../../testing/gtest/include -I../../third_party -I../../third_party/protobuf/src -Igen/protoc_out -I../../third_party/protobuf/src -I../../third_party/protobuf -Igen -I../../third_party/mesa/src/include -I../../third_party/libyuv -I../../third_party/libyuv/include -I../../third_party/webrtc/overrides -I../../third_party -I../../third_party/webrtc/modules/interface -I../../third_party/webrtc/modules/audio_device/include -I../../third_party/webrtc/modules/audio_device/dummy -I../../third_party/libvpx/source/libvpx -fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector -m64 -march=x86-64 -funwind-tables -fPIC -pipe -pthread -B../../third_party/binutils/Linux_x64/Release/bin -fcolor-diagnostics -Wall -Wsign-compare -Wendif-labels -Werror -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-char-subscripts -Wno-covered-switch-default -Wno-deprecated-register -Wno-unneeded-internal-declaration -Wno-reserved-user-defined-literal -Wno-inconsistent-missing-override -Wno-shift-negative-value -fvisibility=hidden -Xclang -load -Xclang ../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so -Xclang -plugin-arg-find-bad-constructs -Xclang check-templates -Xclang -add-plugin -Xclang find-bad-constructs -Wheader-hygiene -Wstring-conversion -O0 -g2 -gsplit-dwarf -Wno-header-guard -Wno-incompatible-pointer-types -Wthread-safety -fno-threadsafe-statics -fvisibility-inlines-hidden -Wno-undefined-bool-conversion -Wno-tautological-undefined-compare -std=gnu++11 -fno-rtti -fno-exceptions -c ../../content/renderer/usb/web_usb_client_impl.cc -o obj/content/renderer/renderer/web_usb_client_impl.o In file included from ../../content/renderer/usb/web_usb_client_impl.cc:14: ../../content/renderer/usb/web_usb_device_impl.h:17:10: fatal error: 'third_party/mojo/src/mojo/public/cpp/bindings/error_handler.h' file not found #include "third_party/mojo/src/mojo/public/cpp/bindings/error_handler.h" Original issue's description: > Update mojo sdk to rev c02a28868825edfa57ab77947b8cb15e741c5598 > > This updates lots of code which was missing an include of > mojo/public/cpp/bindings/binding.h (which used to be included > transitively from mojom-generated headers), and gets rid of > references to mojo::ErrorHandler. > > BUG=None > TBR=jam@chromium.org,ben@chromium.org > TBR=mfoltz@chromium.org > TBR=mek@chromium.org > TBR=xhwang@chromium.org > TBR=shess@chromium.org > > Committed: https://crrev.com/0b56a692d5c342a7093c361ff6ccb464c9d54947 > Cr-Commit-Position: refs/heads/master@{#344957} TBR=ben@chromium.org,jam@chromium.org,rockot@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=None Committed: https://crrev.com/b83114bc5c6ad0b6bfef4f0589bd49216630169c Cr-Commit-Position: refs/heads/master@{#344959}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1058 lines, -2504 lines) Patch
D build/module_args/dart.gni View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/media/router/media_router_mojo_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/media/router/media_router_mojo_test.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/devtools_service/devtools_http_server.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/filesystem/files_test_base.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/html_viewer/document_resource_waiter.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/html_viewer/html_frame.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/html_viewer/html_frame.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/html_viewer/web_socket_handle_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/presentation/presentation_service_impl.h View 3 chunks +5 lines, -1 line 0 comments Download
M content/browser/presentation/presentation_service_impl.cc View 1 chunk +6 lines, -4 lines 0 comments Download
M content/child/navigator_connect/service_port_provider.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/presentation/presentation_dispatcher.h View 2 chunks +0 lines, -3 lines 0 comments Download
M device/serial/data_receiver.h View 1 chunk +0 lines, -1 line 0 comments Download
M device/serial/data_sink_receiver.h View 1 chunk +0 lines, -1 line 0 comments Download
M device/serial/data_source_sender.h View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/browser/mojo/stash_backend_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M ipc/mojo/ipc_channel_mojo.cc View 1 chunk +0 lines, -1 line 0 comments Download
M mandoline/ui/aura/surface_binding.cc View 1 chunk +0 lines, -1 line 0 comments Download
M media/mojo/services/mojo_cdm.h View 1 chunk +0 lines, -1 line 0 comments Download
M media/mojo/services/mojo_renderer_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/application/public/cpp/application_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/application/public/cpp/lib/service_registry.h View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/gles2/command_buffer_client_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/runner/child_process.cc View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/tools/rev_sdk.py View 1 chunk +0 lines, -1 line 0 comments Download
M sql/mojo/sql_test_base.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/mojo/mojo_edk.gyp View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/mojo/mojo_edk_system_impl.gypi View 3 chunks +0 lines, -4 lines 0 comments Download
M third_party/mojo/mojo_edk_tests.gyp View 5 chunks +0 lines, -23 lines 0 comments Download
M third_party/mojo/mojo_public.gyp View 3 chunks +3 lines, -1 line 0 comments Download
M third_party/mojo/src/mojo/edk/embedder/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/mojo/src/mojo/edk/embedder/embedder_unittest.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M third_party/mojo/src/mojo/edk/embedder/platform_channel_pair_posix_unittest.cc View 5 chunks +15 lines, -2 lines 0 comments Download
M third_party/mojo/src/mojo/edk/embedder/simple_platform_support.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/mojo/src/mojo/edk/js/tests/js_to_cpp_tests.cc View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/mojo/src/mojo/edk/mojo_edk.gni View 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/BUILD.gn View 4 chunks +0 lines, -5 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/channel.h View 3 chunks +17 lines, -21 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/channel.cc View 16 chunks +15 lines, -18 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/channel_endpoint.h View 5 chunks +19 lines, -21 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/channel_endpoint.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/channel_manager.h View 2 chunks +4 lines, -7 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/channel_manager.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/connection_manager.h View 4 chunks +9 lines, -29 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/connection_manager_unittest.cc View 10 chunks +26 lines, -41 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/core.h View 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/core.cc View 12 chunks +12 lines, -12 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/core_test_base.h View 2 chunks +18 lines, -18 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/core_test_base.cc View 10 chunks +45 lines, -45 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/data_pipe_consumer_dispatcher.h View 3 chunks +6 lines, -8 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/data_pipe_consumer_dispatcher.cc View 8 chunks +10 lines, -15 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/data_pipe_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/edk/system/data_pipe_producer_dispatcher.h View 3 chunks +6 lines, -8 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/data_pipe_producer_dispatcher.cc View 8 chunks +10 lines, -15 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/dispatcher.h View 8 chunks +50 lines, -72 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/dispatcher.cc View 31 chunks +37 lines, -39 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/dispatcher_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/edk/system/endpoint_relayer.h View 3 chunks +7 lines, -6 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/endpoint_relayer.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/incoming_endpoint.h View 3 chunks +5 lines, -5 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/incoming_endpoint.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/ipc_support.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/master_connection_manager.h View 5 chunks +16 lines, -17 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/master_connection_manager.cc View 16 chunks +31 lines, -78 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/message_in_transit.h View 1 chunk +3 lines, -10 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/message_pipe_dispatcher.h View 2 chunks +6 lines, -9 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/message_pipe_dispatcher.cc View 6 chunks +10 lines, -10 lines 0 comments Download
D third_party/mojo/src/mojo/edk/system/mutex.h View 1 chunk +0 lines, -93 lines 0 comments Download
D third_party/mojo/src/mojo/edk/system/mutex.cc View 1 chunk +0 lines, -38 lines 0 comments Download
D third_party/mojo/src/mojo/edk/system/mutex_unittest.cc View 1 chunk +0 lines, -250 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/platform_handle_dispatcher.h View 1 chunk +3 lines, -5 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/platform_handle_dispatcher.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/raw_channel_unittest.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/shared_buffer_dispatcher.h View 1 chunk +3 lines, -6 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/shared_buffer_dispatcher.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/simple_dispatcher.h View 2 chunks +5 lines, -3 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/simple_dispatcher.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/simple_dispatcher_unittest.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/slave_connection_manager.h View 4 chunks +9 lines, -9 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/slave_connection_manager.cc View 11 chunks +49 lines, -66 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/test_channel_endpoint_client.h View 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/test_channel_endpoint_client.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/test_utils.h View 1 chunk +1 line, -1 line 0 comments Download
D third_party/mojo/src/mojo/edk/system/thread_annotations.h View 1 chunk +0 lines, -85 lines 0 comments Download
D third_party/mojo/src/mojo/edk/system/thread_annotations_unittest.cc View 1 chunk +0 lines, -124 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/waiter_unittest.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M third_party/mojo/src/mojo/edk/test/BUILD.gn View 2 chunks +0 lines, -8 lines 0 comments Download
M third_party/mojo/src/mojo/public/VERSION View 1 chunk +1 line, -1 line 0 comments Download
D third_party/mojo/src/mojo/public/c/gpu/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/mojo/src/mojo/public/cpp/bindings/BUILD.gn View 2 chunks +3 lines, -0 lines 0 comments Download
M third_party/mojo/src/mojo/public/cpp/bindings/binding.h View 3 chunks +16 lines, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/cpp/bindings/callback.h View 4 chunks +2 lines, -21 lines 0 comments Download
A third_party/mojo/src/mojo/public/cpp/bindings/error_handler.h View 1 chunk +19 lines, -0 lines 0 comments Download
A third_party/mojo/src/mojo/public/cpp/bindings/interface_impl.h View 1 chunk +178 lines, -0 lines 0 comments Download
M third_party/mojo/src/mojo/public/cpp/bindings/interface_ptr.h View 3 chunks +14 lines, -3 lines 0 comments Download
M third_party/mojo/src/mojo/public/cpp/bindings/lib/connector.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/mojo/src/mojo/public/cpp/bindings/lib/connector.cc View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/mojo/src/mojo/public/cpp/bindings/lib/map_data_internal.h View 1 chunk +6 lines, -9 lines 0 comments Download
A third_party/mojo/src/mojo/public/cpp/bindings/lib/message_queue.h View 1 chunk +47 lines, -0 lines 0 comments Download
A third_party/mojo/src/mojo/public/cpp/bindings/lib/message_queue.cc View 1 chunk +48 lines, -0 lines 0 comments Download
M third_party/mojo/src/mojo/public/cpp/bindings/strong_binding.h View 2 chunks +12 lines, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/cpp/bindings/tests/BUILD.gn View 2 chunks +0 lines, -24 lines 0 comments Download
M third_party/mojo/src/mojo/public/cpp/bindings/tests/binding_callback_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/cpp/bindings/tests/binding_unittest.cc View 8 chunks +27 lines, -225 lines 0 comments Download
D third_party/mojo/src/mojo/public/cpp/bindings/tests/bindings_perftest.cc View 1 chunk +0 lines, -127 lines 0 comments Download
M third_party/mojo/src/mojo/public/cpp/bindings/tests/callback_unittest.cc View 3 chunks +2 lines, -70 lines 0 comments Download
M third_party/mojo/src/mojo/public/cpp/bindings/tests/connector_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/mojo/src/mojo/public/cpp/bindings/tests/interface_ptr_unittest.cc View 1 chunk +0 lines, -7 lines 0 comments Download
D third_party/mojo/src/mojo/public/cpp/bindings/tests/message_queue.h View 1 chunk +0 lines, -43 lines 0 comments Download
D third_party/mojo/src/mojo/public/cpp/bindings/tests/message_queue.cc View 1 chunk +0 lines, -43 lines 0 comments Download
M third_party/mojo/src/mojo/public/cpp/bindings/tests/request_response_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/cpp/bindings/tests/router_unittest.cc View 9 chunks +9 lines, -9 lines 0 comments Download
M third_party/mojo/src/mojo/public/cpp/bindings/tests/validation_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D third_party/mojo/src/mojo/public/dart/.analysis_options View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/mojo/src/mojo/public/dart/.gitignore View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/mojo/src/mojo/public/dart/BUILD.gn View 2 chunks +4 lines, -3 lines 0 comments Download
M third_party/mojo/src/mojo/public/dart/CHANGELOG.md View 1 chunk +0 lines, -20 lines 0 comments Download
A third_party/mojo/src/mojo/public/dart/lib/io.dart View 1 chunk +49 lines, -0 lines 0 comments Download
M third_party/mojo/src/mojo/public/dart/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/dart/rules.gni View 5 chunks +3 lines, -21 lines 0 comments Download
M third_party/mojo/src/mojo/public/interfaces/bindings/tests/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/mojo/src/mojo/public/interfaces/bindings/tests/ping_service.mojom View 1 chunk +0 lines, -10 lines 0 comments Download
M third_party/mojo/src/mojo/public/interfaces/bindings/tests/test_unions.mojom View 2 chunks +0 lines, -10 lines 0 comments Download
M third_party/mojo/src/mojo/public/mojo_application.gni View 7 chunks +24 lines, -131 lines 0 comments Download
M third_party/mojo/src/mojo/public/python/mojo_bindings/descriptor.py View 3 chunks +2 lines, -53 lines 0 comments Download
M third_party/mojo/src/mojo/public/python/mojo_bindings/reflection.py View 1 chunk +0 lines, -97 lines 0 comments Download
M third_party/mojo/src/mojo/public/python/mojo_bindings/serialization.py View 2 chunks +1 line, -90 lines 0 comments Download
M third_party/mojo/src/mojo/public/tools/NETWORK_SERVICE_VERSION View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/generators/cpp_templates/enum_declaration.tmpl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/generators/cpp_templates/module.h.tmpl View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/generators/java_templates/interface_definition.tmpl View 1 chunk +7 lines, -7 lines 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/generators/mojom_dart_generator.py View 2 chunks +10 lines, -16 lines 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/generators/mojom_python_generator.py View 5 chunks +7 lines, -21 lines 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/generators/python_templates/module.py.tmpl View 2 chunks +0 lines, -8 lines 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/generators/python_templates/module_macros.tmpl View 1 chunk +0 lines, -10 lines 0 comments Download
M third_party/mojo/src/mojo/public/tools/dart_pkg.py View 5 chunks +5 lines, -44 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
yosin_UTC9
Created Revert of Update mojo sdk to rev c02a28868825edfa57ab77947b8cb15e741c5598
5 years, 4 months ago (2015-08-22 03:01:22 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311613002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311613002/1
5 years, 4 months ago (2015-08-22 03:01:49 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-22 03:03:06 UTC) #3
commit-bot: I haz the power
5 years, 4 months ago (2015-08-22 03:03:39 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b83114bc5c6ad0b6bfef4f0589bd49216630169c
Cr-Commit-Position: refs/heads/master@{#344959}

Powered by Google App Engine
This is Rietveld 408576698