utils/pub/path_source.dart - Issue 13116020: Clean up the semantics of io.dart operations w.r.t. symlinks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: utils/pub/path_source.dart

Issue 13116020: Clean up the semantics of io.dart operations w.r.t. symlinks. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Code review changes Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: utils/pub/path_source.dart

diff --git a/utils/pub/path_source.dart b/utils/pub/path_source.dart

index 6cdc0707bbb76add33eaf057f917a809446c3060..8b3b7a50f7167b96c33fe8a8791c25bac0a5a12a 100644

--- a/utils/pub/path_source.dart

+++ b/utils/pub/path_source.dart

@@ -108,8 +108,6 @@ class PathSource extends Source {

if (dirExists(dir)) return;

- // Check this after dirExists() so that symlinks to directories don't get

- // confused as files.

if (fileExists(dir)) {

throw new FormatException(

"Path dependency for package '$name' must refer to a "

« no previous file with comments | « utils/pub/oauth2.dart ('k') | utils/pub/pub.dart » ('j') | no next file with comments »