Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1311593003: DevTools: [timeline tree] extract URL from event initiator (Closed)

Created:
5 years, 4 months ago by alph
Modified:
5 years, 4 months ago
Reviewers:
caseq
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

DevTools: [timeline tree] extract URL from event initiator BUG=523588 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201038

Patch Set 1 #

Total comments: 2

Patch Set 2 : addressing comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M Source/devtools/front_end/timeline/TimelineTreeView.js View 1 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
alph
5 years, 4 months ago (2015-08-22 00:38:46 UTC) #2
caseq
lgtm w/nit https://codereview.chromium.org/1311593003/diff/1/Source/devtools/front_end/timeline/TimelineTreeView.js File Source/devtools/front_end/timeline/TimelineTreeView.js (right): https://codereview.chromium.org/1311593003/diff/1/Source/devtools/front_end/timeline/TimelineTreeView.js#newcode297 Source/devtools/front_end/timeline/TimelineTreeView.js:297: topFrame = event.initiator && event.initiator.stackTrace && event.initiator.stackTrace[0]; ...
5 years, 4 months ago (2015-08-22 00:42:44 UTC) #3
alph
https://codereview.chromium.org/1311593003/diff/1/Source/devtools/front_end/timeline/TimelineTreeView.js File Source/devtools/front_end/timeline/TimelineTreeView.js (right): https://codereview.chromium.org/1311593003/diff/1/Source/devtools/front_end/timeline/TimelineTreeView.js#newcode297 Source/devtools/front_end/timeline/TimelineTreeView.js:297: topFrame = event.initiator && event.initiator.stackTrace && event.initiator.stackTrace[0]; On 2015/08/22 ...
5 years, 4 months ago (2015-08-22 01:07:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311593003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311593003/20001
5 years, 4 months ago (2015-08-22 01:08:28 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_chromium_compile_only_ng/builds/23342)
5 years, 4 months ago (2015-08-22 01:46:15 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311593003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311593003/20001
5 years, 4 months ago (2015-08-22 01:47:13 UTC) #11
commit-bot: I haz the power
5 years, 4 months ago (2015-08-22 04:08:05 UTC) #12
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201038

Powered by Google App Engine
This is Rietveld 408576698