Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 1311583006: Revert of Add command_buffer_gles2 (Closed)

Created:
5 years, 3 months ago by Jamie Madill
Modified:
5 years, 3 months ago
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add command_buffer_gles2 (patchset #16 id:350001 of https://codereview.chromium.org/1220883008/ ) Reason for revert: This breaks the gles2_conform_test in Linux Release, Mac Release and some Windows Release configurations. Original issue's description: > Add command_buffer_gles2 > > This is a very simple library that exposes some egl-like functions that > can be used by skia to use the command buffer as a backend for their > tests > > Committed: https://crrev.com/604b615373e4e9f873db37cef9c6416176fc35f3 > Cr-Commit-Position: refs/heads/master@{#346251} > > Committed: https://crrev.com/efa3a446183fbbff2034a03989f12543d0713e39 > Cr-Commit-Position: refs/heads/master@{#346840} > > Committed: https://crrev.com/d65c55dac3f47e9a237579eb6f5fe31e19ca4704 > Cr-Commit-Position: refs/heads/master@{#347013} > > Committed: https://crrev.com/a89ffff5113b3feb0c905f7ddc50da84a4ed577b > Cr-Commit-Position: refs/heads/master@{#347103} TBR=piman@chromium.org,dpranke@chromium.org,sievers@chromium.org,hendrikw@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/fc080e09b4c22b85354e9ba541b87d22aa9b8fe8 Cr-Commit-Position: refs/heads/master@{#347151}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -216 lines) Patch
M gpu/BUILD.gn View 1 chunk +0 lines, -36 lines 0 comments Download
M gpu/gles2_conform_support/egl/display.h View 2 chunks +0 lines, -12 lines 0 comments Download
M gpu/gles2_conform_support/egl/display.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M gpu/gles2_conform_support/egl/egl.cc View 14 chunks +117 lines, -127 lines 0 comments Download
M gpu/gpu.gyp View 1 chunk +0 lines, -37 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Jamie Madill
Created Revert of Add command_buffer_gles2
5 years, 3 months ago (2015-09-03 14:33:16 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311583006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311583006/1
5 years, 3 months ago (2015-09-03 14:33:34 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-03 14:34:14 UTC) #3
commit-bot: I haz the power
5 years, 3 months ago (2015-09-03 14:35:07 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fc080e09b4c22b85354e9ba541b87d22aa9b8fe8
Cr-Commit-Position: refs/heads/master@{#347151}

Powered by Google App Engine
This is Rietveld 408576698