Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1311533007: Replace references to old blink isolate files in gtest_test_instance.py. (Closed)

Created:
5 years, 3 months ago by joelo
Modified:
5 years, 3 months ago
Reviewers:
Dirk Pranke, M-A Ruel
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace references to old blink isolate files in gtest_test_instance.py. BUG=524758 Committed: https://crrev.com/1f9c42098fe19c3daf4611fc58442009abd3ada9 Cr-Commit-Position: refs/heads/master@{#346808}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M build/android/pylib/gtest/gtest_test_instance.py View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
joelo
depends on https://codereview.chromium.org/1320253003/
5 years, 3 months ago (2015-09-01 01:55:15 UTC) #2
Dirk Pranke
lgtm
5 years, 3 months ago (2015-09-01 18:55:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311533007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311533007/1
5 years, 3 months ago (2015-09-01 23:55:31 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-02 01:04:55 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/1f9c42098fe19c3daf4611fc58442009abd3ada9 Cr-Commit-Position: refs/heads/master@{#346808}
5 years, 3 months ago (2015-09-02 01:05:39 UTC) #7
joelo
5 years, 3 months ago (2015-09-02 03:22:12 UTC) #8
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1323073004/ by joelo@chromium.org.

The reason for reverting is: broke android build, new isolate file probably
needs an android clause

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Android%20%28N....

Powered by Google App Engine
This is Rietveld 408576698