Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(503)

Issue 1311503008: draw 3 moveTos followed by various others [moves, lines, closes] (Closed)

Created:
5 years, 3 months ago by reed1
Modified:
5 years, 3 months ago
Reviewers:
caryclark
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

draw 3 moveTos followed by various others [moves, lines, closes] BUG=skia: Committed: https://skia.googlesource.com/skia/+/58e524c98c1d575d37d7ef55f0e2498192ca880f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -2 lines) Patch
M gm/emptypath.cpp View 1 chunk +77 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
reed1
5 years, 3 months ago (2015-09-04 16:16:00 UTC) #2
reed1
ptal
5 years, 3 months ago (2015-09-04 16:16:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311503008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311503008/1
5 years, 3 months ago (2015-09-04 16:16:14 UTC) #5
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 3 months ago (2015-09-04 16:16:15 UTC) #6
caryclark
lgtm
5 years, 3 months ago (2015-09-04 17:01:50 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/58e524c98c1d575d37d7ef55f0e2498192ca880f
5 years, 3 months ago (2015-09-04 17:03:29 UTC) #8
jcgregorio
5 years, 3 months ago (2015-09-04 20:40:52 UTC) #9
Message was sent while issue was closed.
On 2015/09/04 at 17:03:29, commit-bot wrote:
> Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/58e524c98c1d575d37d7ef55f0e2498192ca880f

Is this CL is causing this breakage?:


 
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-Clang-GCE-CPU-AV...



../../../gm/emptypath.cpp:172:14: error: 'onShortName' overrides a member
function but is not marked 'override' [-Werror,-Winconsistent-missing-override]
    SkString onShortName() {
             ^
../../../gm/gm.h:103:26: note: overridden virtual function is here
        virtual SkString onShortName() = 0;
                         ^

Powered by Google App Engine
This is Rietveld 408576698