Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1355)

Unified Diff: runtime/observatory/lib/src/service/object.dart

Issue 1311503004: Remember when an isolate was paused and subtly display it in Obseravatory (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/lib/src/service/object.dart
diff --git a/runtime/observatory/lib/src/service/object.dart b/runtime/observatory/lib/src/service/object.dart
index d2dade6a58f2301db89a2ddbf44d9c70cb06e160..8907a8ee84bd9392396a4f07d37153033e679645 100644
--- a/runtime/observatory/lib/src/service/object.dart
+++ b/runtime/observatory/lib/src/service/object.dart
@@ -767,7 +767,7 @@ abstract class VM extends ServiceObjectOwner {
version = map['version'];
targetCPU = map['targetCPU'];
architectureBits = map['architectureBits'];
- var startTimeMillis = map['startTime'];
+ var startTimeMillis = map['startTime'].toInt();
startTime = new DateTime.fromMillisecondsSinceEpoch(startTimeMillis);
refreshTime = new DateTime.now();
notifyPropertyChange(#upTime, 0, 1);
@@ -1238,7 +1238,7 @@ class Isolate extends ServiceObjectOwner with Coverage {
entry = map['entry'];
}
var savedStartTime = startTime;
- var startTimeInMillis = map['startTime'];
+ var startTimeInMillis = map['startTime'].toInt();
startTime = new DateTime.fromMillisecondsSinceEpoch(startTimeInMillis);
notifyPropertyChange(#upTime, 0, 1);
var countersMap = map['_tagCounters'];
@@ -1733,6 +1733,7 @@ class ServiceEvent extends ServiceObject {
}
@observable String kind;
+ @observable DateTime timestamp;
@observable Breakpoint breakpoint;
@observable Frame topFrame;
@observable Instance exception;
@@ -1745,6 +1746,7 @@ class ServiceEvent extends ServiceObject {
@observable String exceptions;
@observable String bytesAsString;
@observable Map logRecord;
+
int chunkIndex, chunkCount, nodeCount;
@observable bool get isPauseEvent {
@@ -1759,6 +1761,8 @@ class ServiceEvent extends ServiceObject {
_loaded = true;
_upgradeCollection(map, owner);
assert(map['isolate'] == null || owner == map['isolate']);
+ timestamp =
+ new DateTime.fromMillisecondsSinceEpoch(map['timestamp'].toInt());
kind = map['kind'];
notifyPropertyChange(#isPauseEvent, 0, 1);
name = 'ServiceEvent $kind';

Powered by Google App Engine
This is Rietveld 408576698