Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 1311473007: MIPS: Fix QuietSignalingNaNs on mips32r6. (Closed)

Created:
5 years, 3 months ago by akos.palfi.imgtec
Modified:
5 years, 3 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Fix QuietSignalingNaNs on mips32r6. Use the correct sNaN value on mips32r6 also. TEST=test-api/QuietSignalingNaNs,test-api/Threading1 BUG= Committed: https://crrev.com/ae3185e390551dd9baabd4373715477f7da378ae Cr-Commit-Position: refs/heads/master@{#30510}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M test/cctest/test-api.cc View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
akos.palfi.imgtec
Hi Benedikt, Michael, This fixes a cctest failure on mips32r6, PTAL. Thanks, Akos
5 years, 3 months ago (2015-09-01 11:18:25 UTC) #2
Michael Starzinger
LGTM (rubber-stamped).
5 years, 3 months ago (2015-09-01 11:53:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311473007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311473007/1
5 years, 3 months ago (2015-09-01 12:20:43 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-01 12:44:17 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-01 12:44:52 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ae3185e390551dd9baabd4373715477f7da378ae
Cr-Commit-Position: refs/heads/master@{#30510}

Powered by Google App Engine
This is Rietveld 408576698