Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1311463004: Invalidate style from shadow host, not root, to apply :host rules. (Closed)

Created:
5 years, 3 months ago by rune
Modified:
5 years, 3 months ago
Reviewers:
esprehn
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, dglazkov+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Invalidate style from shadow host, not root, to apply :host rules. This is a regression from r201058. We incorrectly marked the shadow root node for style recalc instead of the host. Marking the host is necessary to apply new :host rules. R=esprehn@chromium.org BUG=525280 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201311

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -9 lines) Patch
M LayoutTests/fast/css/invalidation/shadow-add-sheet-content.html View 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/fast/css/invalidation/shadow-add-sheet-content-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
A LayoutTests/fast/css/invalidation/shadow-add-sheet-host.html View 1 chunk +36 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/invalidation/shadow-add-sheet-host-expected.txt View 1 chunk +12 lines, -0 lines 0 comments Download
M Source/core/css/invalidation/StyleSheetInvalidationAnalysis.cpp View 2 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
rune
5 years, 3 months ago (2015-08-27 09:39:02 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311463004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311463004/1
5 years, 3 months ago (2015-08-27 09:39:15 UTC) #3
esprehn
lgtm, thanks!
5 years, 3 months ago (2015-08-27 10:01:34 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-08-27 12:03:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311463004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311463004/1
5 years, 3 months ago (2015-08-27 13:20:25 UTC) #8
commit-bot: I haz the power
5 years, 3 months ago (2015-08-27 13:25:19 UTC) #9
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201311

Powered by Google App Engine
This is Rietveld 408576698