Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Unified Diff: pkg/analyzer/test/src/task/strong_mode_test.dart

Issue 1311433005: Integrate recent parameter override logic (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer/test/src/task/strong_mode_test.dart
diff --git a/pkg/analyzer/test/src/task/strong_mode_test.dart b/pkg/analyzer/test/src/task/strong_mode_test.dart
index 3891f67b2f28d86bb10a6af1ef68b6f548e2e136..084c9bd9968bfdb7cc3537c9c3a73eb7ee9abef3 100644
--- a/pkg/analyzer/test/src/task/strong_mode_test.dart
+++ b/pkg/analyzer/test/src/task/strong_mode_test.dart
@@ -445,7 +445,135 @@ class C extends B {}
inferrer.inferCompilationUnit(unit);
}
- void test_inferCompilationUnit_method_multiple_different() {
+ void test_inferCompilationUnit_method_parameter_multiple_different() {
+ InstanceMemberInferrer inferrer = createInferrer;
+ String methodName = 'm';
+ CompilationUnitElement unit = resolve('''
+class A {
+ $methodName(int p) => 0;
+}
+class B {
+ $methodName(double p) => 0;
+}
+class C implements A, B {
+ $methodName(p) => 0;
+}
+''');
+ ClassElement classC = unit.getType('C');
+ MethodElement methodC = classC.getMethod(methodName);
+ ParameterElement parameterC = methodC.parameters[0];
+ expect(parameterC.type.isDynamic, isTrue);
+
+ inferrer.inferCompilationUnit(unit);
+
+ expect(parameterC.type.isDynamic, isTrue);
+ }
+
+ void test_inferCompilationUnit_method_parameter_multiple_named_different() {
+ InstanceMemberInferrer inferrer = createInferrer;
+ String methodName = 'm';
+ CompilationUnitElement unit = resolve('''
+class A {
+ $methodName({int p}) => 0;
+}
+class B {
+ $methodName({int q}) => 0;
+}
+class C implements A, B {
+ $methodName({p}) => 0;
+}
+''');
+ ClassElement classC = unit.getType('C');
+ MethodElement methodC = classC.getMethod(methodName);
+ ParameterElement parameterC = methodC.parameters[0];
+ expect(parameterC.type.isDynamic, isTrue);
+
+ inferrer.inferCompilationUnit(unit);
+
+ expect(parameterC.type.isDynamic, isTrue);
+ }
+
+ void test_inferCompilationUnit_method_parameter_multiple_named_same() {
+ InstanceMemberInferrer inferrer = createInferrer;
+ String methodName = 'm';
+ CompilationUnitElement unit = resolve('''
+class A {
+ $methodName({int p}) => 0;
+}
+class B {
+ $methodName({int p}) => 0;
+}
+class C implements A, B {
+ $methodName({p}) => 0;
+}
+''');
+ ClassElement classA = unit.getType('A');
+ MethodElement methodA = classA.getMethod(methodName);
+ ParameterElement parameterA = methodA.parameters[0];
+ DartType expectedType = parameterA.type;
+ ClassElement classC = unit.getType('C');
+ MethodElement methodC = classC.getMethod(methodName);
+ ParameterElement parameterC = methodC.parameters[0];
+ expect(parameterC.type.isDynamic, isTrue);
+
+ inferrer.inferCompilationUnit(unit);
+
+ expect(parameterC.type, expectedType);
+ }
+
+ void test_inferCompilationUnit_method_parameter_multiple_namedAndRequired() {
+ InstanceMemberInferrer inferrer = createInferrer;
+ String methodName = 'm';
+ CompilationUnitElement unit = resolve('''
+class A {
+ $methodName({int p}) => 0;
+}
+class B {
+ $methodName(int p) => 0;
+}
+class C implements A, B {
+ $methodName(p) => 0;
+}
+''');
+ ClassElement classC = unit.getType('C');
+ MethodElement methodC = classC.getMethod(methodName);
+ ParameterElement parameterC = methodC.parameters[0];
+ expect(parameterC.type.isDynamic, isTrue);
+
+ inferrer.inferCompilationUnit(unit);
+
+ expect(parameterC.type.isDynamic, isTrue);
+ }
+
+ void test_inferCompilationUnit_method_parameter_multiple_optionalAndRequired() {
+ InstanceMemberInferrer inferrer = createInferrer;
+ String methodName = 'm';
+ CompilationUnitElement unit = resolve('''
+class A {
+ $methodName(int p) => 0;
+}
+class B {
+ $methodName([int p]) => 0;
+}
+class C implements A, B {
+ $methodName(p) => 0;
+}
+''');
+ ClassElement classA = unit.getType('A');
+ MethodElement methodA = classA.getMethod(methodName);
+ ParameterElement parameterA = methodA.parameters[0];
+ DartType expectedType = parameterA.type;
+ ClassElement classC = unit.getType('C');
+ MethodElement methodC = classC.getMethod(methodName);
+ ParameterElement parameterC = methodC.parameters[0];
+ expect(parameterC.type.isDynamic, isTrue);
+
+ inferrer.inferCompilationUnit(unit);
+
+ expect(parameterC.type, expectedType);
+ }
+
+ void test_inferCompilationUnit_method_return_multiple_different() {
InstanceMemberInferrer inferrer = createInferrer;
String methodName = 'm';
CompilationUnitElement unit = resolve('''
@@ -468,7 +596,7 @@ class C implements A, B {
expect(methodC.returnType.isDynamic, isTrue);
}
- void test_inferCompilationUnit_method_multiple_dynamic() {
+ void test_inferCompilationUnit_method_return_multiple_dynamic() {
InstanceMemberInferrer inferrer = createInferrer;
String methodName = 'm';
CompilationUnitElement unit = resolve('''
@@ -491,7 +619,7 @@ class C implements A, B {
expect(methodC.returnType.isDynamic, isTrue);
}
- void test_inferCompilationUnit_method_multiple_same_nonVoid() {
+ void test_inferCompilationUnit_method_return_multiple_same_nonVoid() {
InstanceMemberInferrer inferrer = createInferrer;
String methodName = 'm';
CompilationUnitElement unit = resolve('''
@@ -517,7 +645,7 @@ class C implements A, B {
expect(methodC.returnType, expectedType);
}
- void test_inferCompilationUnit_method_multiple_same_void() {
+ void test_inferCompilationUnit_method_return_multiple_same_void() {
InstanceMemberInferrer inferrer = createInferrer;
String methodName = 'm';
CompilationUnitElement unit = resolve('''
@@ -543,7 +671,7 @@ class C implements A, B {
expect(methodC.returnType, expectedType);
}
- void test_inferCompilationUnit_method_multiple_void() {
+ void test_inferCompilationUnit_method_return_multiple_void() {
InstanceMemberInferrer inferrer = createInferrer;
String methodName = 'm';
CompilationUnitElement unit = resolve('''
@@ -566,7 +694,7 @@ class C implements A, B {
expect(methodC.returnType.isDynamic, isTrue);
}
- void test_inferCompilationUnit_method_single() {
+ void test_inferCompilationUnit_method_return_single() {
InstanceMemberInferrer inferrer = createInferrer;
String methodName = 'm';
CompilationUnitElement unit = resolve('''
« pkg/analyzer/lib/src/task/strong_mode.dart ('K') | « pkg/analyzer/lib/src/task/strong_mode.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698