Integrate recent parameter override logic

pkg/analyzer/lib/src/task/strong_mode.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library analyzer.src.task.strong_mode;
 
 import 'dart:collection';
 
 import 'package:analyzer/src/generated/ast.dart';
 import 'package:analyzer/src/generated/element.dart';
 import 'package:analyzer/src/generated/resolver.dart';
+import 'package:analyzer/src/generated/utilities_dart.dart';
 
 /**
  * An object used to find static variables whose types should be inferred and
  * classes whose members should have types inferred. Clients are expected to
  * visit a [CompilationUnit].
  */
 class InferrenceFinder extends SimpleAstVisitor {
   /**
    * The static variables that should have types inferred for them.
    */
@@ skipping 135 matching lines @@
       try {
         _inferClass(classElement);
       } on _CycleException {
         // This is a short circuit return to prevent types that inherit from
         // types containing a circular reference from being inferred.
       }
     });
   }
 
   /**
+   * Compute the best type for the [parameter] at the given [index] that must be
+   * compatible with the types of the corresponding parameters of the given
+   * [overriddenMethods].
+   *
+   * At the moment, this method will only return a type other than 'dynamic' if
+   * the types of all of the parameters are the same. In the future we might
+   * want to be smarter about it, such as by returning the least upper bound of
+   * the parameter types.
+   */
+  DartType _computeParameterType(ParameterElement parameter, int index,
+      List<ExecutableElement> overriddenMethods) {
+    //
+    // Return the type of the corresponding parameter in the method with the
+    // given [methodIndex].
+    //
+    DartType getOverriddenType(int methodIndex) {
+      //
+      // Find the corresponding parameter.
+      //
+      List<ParameterElement> overriddenParameters =
+          overriddenMethods[methodIndex].parameters;
+      ParameterElement overriddenParameter = null;
+      if (parameter.parameterKind == ParameterKind.NAMED) {
+        //
+        // If we're looking for a named parameter, only a named parameter with
+        // the same name will be matched.
+        //
+        for (int i = overriddenParameters.length - 1; i >= 0; i--) {

[Leaf, 2015/08/25 23:06:37]

I think using 
  overridenParameter = overridenParameters.lastWhere(...) 
instead of a loop here would make the code clearer, but that might be my
misspent youth showing through. 

[Brian Wilkerson, 2015/08/26 15:25:37]

Done

+          overriddenParameter = overriddenParameters[index];

[Leaf, 2015/08/25 23:06:37]

I think this should be i instead of index?

[Brian Wilkerson, 2015/08/26 15:25:37]

Subsumed by previous change.

+          if (overriddenParameter.parameterKind == ParameterKind.NAMED &&
+              overriddenParameter.name == parameter.name) {
+            break;
+          }
+          overriddenParameter = null;
+        }
+      } else {
+        //
+        // If we're looking for a positional parameter we ignore the difference
+        // between required and optional parameters.
+        //
+        if (index < overriddenParameters.length) {
+          overriddenParameter = overriddenParameters[index];
+          if (overriddenParameter.parameterKind == ParameterKind.NAMED) {
+            overriddenParameter = null;
+          }
+        }
+      }
+      //
+      // Then get the type of the parameter.
+      //
+      if (overriddenParameter == null) {
+        return typeProvider.dynamicType;
+      }
+      DartType type = overriddenParameter.type;
+      if (type is TypeParameterType) {

[Leaf, 2015/08/25 23:06:37]

Hmm, is this to address the possibility that the overridden method came from a
generic class, and we have an uninstantiated type?  I think this probably means
we should be using the instantiated types here (Members maybe they're called?). 

[Brian Wilkerson, 2015/08/26 15:25:37]

Yes, but we do have the instantiated type, so this test was unnecessary (and
wrong). I've remove it and added some tests to cover a small number of cases
involving generic types.

+        return typeProvider.dynamicType;
+      }
+      return type;
+    }
+    DartType parameterType = null;
+    int length = overriddenMethods.length;
+    for (int i = 0; i < length; i++) {
+      DartType type = getOverriddenType(i);
+      if (parameterType == null) {
+        parameterType = type;
+      } else if (parameterType != type) {
+        return typeProvider.dynamicType;
+      }
+    }
+    return parameterType == null ? typeProvider.dynamicType : parameterType;
+  }
+
+  /**
    * Compute the best return type for a method that must be compatible with the
    * return types of each of the given [overriddenMethods].
    *
    * At the moment, this method will only return a type other than 'dynamic' if
    * the return types of all of the methods are the same. In the future we might
    * want to be smarter about it.
    */
   DartType _computeReturnType(List<ExecutableElement> overriddenMethods) {
     DartType returnType = null;
     int length = overriddenMethods.length;
@@ skipping 140 matching lines @@
         _setParameterType(fieldElement.setter, newType);
       }
     }
   }
 
   /**
    * If the given [methodElement] represents a non-synthetic instance method
    * for which no return type was provided, infer the return type of the method.
    */
   void _inferMethod(MethodElement methodElement) {
-    if (!methodElement.isSynthetic &&
-        !methodElement.isStatic &&
-        methodElement.hasImplicitReturnType &&
+    if (methodElement.isSynthetic || methodElement.isStatic) {
+      return;
+    }
+    List<ExecutableElement> overriddenMethods = null;
+    //
+    // Infer the return type.
+    //
+    if (methodElement.hasImplicitReturnType &&
         _getReturnType(methodElement).isDynamic) {
-      List<ExecutableElement> overriddenMethods = inheritanceManager
-          .lookupOverrides(methodElement.enclosingElement, methodElement.name);
-      if (overriddenMethods.isNotEmpty && _onlyMethods(overriddenMethods)) {
-        MethodElementImpl element = methodElement as MethodElementImpl;
-        _setReturnType(element, _computeReturnType(overriddenMethods));
+      overriddenMethods = inheritanceManager.lookupOverrides(
+          methodElement.enclosingElement, methodElement.name);
+      if (overriddenMethods.isEmpty || !_onlyMethods(overriddenMethods)) {
+        return;
+      }
+      MethodElementImpl element = methodElement as MethodElementImpl;
+      _setReturnType(element, _computeReturnType(overriddenMethods));
+    }
+    //
+    // Infer the parameter types.
+    //
+    List<ParameterElement> parameters = methodElement.parameters;
+    var length = parameters.length;
+    for (int i = 0; i < length; ++i) {
+      ParameterElement parameter = parameters[i];
+      if (parameter.hasImplicitType && parameter.type.isDynamic) {
+        overriddenMethods = overriddenMethods ??
+            inheritanceManager.lookupOverrides(
+                methodElement.enclosingElement, methodElement.name);
+        if (overriddenMethods.isEmpty || !_onlyMethods(overriddenMethods)) {
+          return;
+        }
+        DartType type = _computeParameterType(parameter, i, overriddenMethods);
+        if (!type.isDynamic) {
+          if (parameter is ParameterElementImpl) {
+            parameter.type = type;
+          }
+        }
       }
     }
   }
 
   /**
    * Infer type information for all of the instance members in the given
    * interface [type].
    */
   void _inferType(InterfaceType type) {
     if (type != null) {
@@ skipping 81 matching lines @@
             new FunctionTypeImpl(element, functionType.prunedTypedefs);
       }
     }
   }
 }
 
 /**
  * A class of exception that is not used anywhere else.
  */
 class _CycleException implements Exception {}