Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 131143005: Keyboard height ratio for a11y keyboard. (Closed)

Created:
6 years, 10 months ago by rsadam
Modified:
6 years, 10 months ago
Reviewers:
bshe
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Keyboard height ratio for a11y keyboard. BUG=338456 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248562

Patch Set 1 #

Patch Set 2 : Removed dupe funciton. #

Patch Set 3 : Merge with master. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M ui/keyboard/keyboard_controller.cc View 1 2 1 chunk +9 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
rsadam
6 years, 10 months ago (2014-01-30 16:55:58 UTC) #1
bshe
On 2014/01/30 16:55:58, rsadam wrote lgtm FYI: my CL got lgtm this morning and added ...
6 years, 10 months ago (2014-01-31 15:49:25 UTC) #2
rsadam
Removed the duplicate function!
6 years, 10 months ago (2014-01-31 23:04:36 UTC) #3
rsadam
The CQ bit was checked by rsadam@chromium.org
6 years, 10 months ago (2014-01-31 23:04:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsadam@chromium.org/131143005/30001
6 years, 10 months ago (2014-01-31 23:04:55 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-01-31 23:30:23 UTC) #6
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=221733
6 years, 10 months ago (2014-01-31 23:30:23 UTC) #7
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-01-31 23:30:32 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-01-31 23:30:32 UTC) #9
rsadam
The CQ bit was checked by rsadam@chromium.org
6 years, 10 months ago (2014-02-03 15:01:57 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsadam@chromium.org/131143005/320001
6 years, 10 months ago (2014-02-03 15:02:06 UTC) #11
commit-bot: I haz the power
Change committed as 248562
6 years, 10 months ago (2014-02-03 20:23:03 UTC) #12
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 20:23:07 UTC) #13
commit-bot: I haz the power
6 years, 10 months ago (2014-02-03 20:23:08 UTC) #14
Message was sent while issue was closed. 
CQ bit was unchecked on CL. Ignoring.

Powered by Google App Engine
This is Rietveld 408576698