- Changed instrumentation-service-worker.js so the value NaN can be tested

LayoutTests/http/tests/notifications/resources/instrumentation-service-worker.js

 importScripts('/resources/testharness-helpers.js');
 
+// For copying Notification.data. Currently a deep copy algorithm is used. Note
+// that the robustness of this function (and also |assert_object_equals| in
+// testharness.js) affects the types of possible testing can be done.
+// TODO(peter): change this to a structured clone algorithm.
+function cloneObject(src) {
+    if (typeof src != 'object')

[Peter Beverloo, 2015/09/01 15:31:44]

nit: could change this to the following, which matches the branch in
serviceworker-notificationclick-event-data-reflection.html more closely.

(typeof src !== 'object' || src === null)

(And remove lines 10-11.)

[lwchkg, 2015/09/01 16:21:09]

Sounds good.

+        return src;
+    if (src === null)
+        return null;
+    var dst = Array.isArray(src) ? [] : {};
+    for (var property in src) {
+        if (src.hasOwnProperty(property)) {

[Peter Beverloo, 2015/09/01 15:31:44]

nit: no need for {} (one-statement if clause)

[lwchkg, 2015/09/01 16:21:09]

Acknowledged.

+            dst[property] = cloneObject(src[property]);
+        }
+    }
+    return dst;
+}
+
 // Copies the serializable attributes of |notification|.
 function cloneNotification(notification) {
-    return JSON.parse(stringifyDOMObject(notification));
+    var dst = JSON.parse(stringifyDOMObject(notification));

[Peter Beverloo, 2015/09/01 15:31:44]

nit: could we name this "copiedNotification"? We prefer appropriately named
variable over the shorter convenient ones in Blink.

(Although I think "src" in cloneObject() is clear enough, sorry for the
inconsistency :-).)

[lwchkg, 2015/09/01 16:21:09]

Sounds good. Agree that "dst" is not clear enough. Actually the string "dst" was
copied from harness-helper.js, and it took me at least a few seconds to
recognize the pattern.

+    dst.data = cloneObject(notification.data);
+    return dst;
 }
 
 // Allows a document to exercise the Notifications API within a service worker by sending commands.
 var messagePort = null;
 
 addEventListener('message', function(workerEvent) {
     messagePort = workerEvent.data;
 
     // Listen to incoming commands on the message port.
     messagePort.onmessage = function(event) {
@@ skipping 57 matching lines @@
 
     // Notifications containing "ACTION:OPENWINDOW" in their message will attempt
     // to open a new window for an example URL.
     if (event.notification.body.indexOf('ACTION:OPENWINDOW') != -1)
         event.waitUntil(clients.openWindow('https://example.com/'));
 
     messagePort.postMessage({ command: 'click',
                               notification: notificationCopy,
                               action: event.action });
 });