Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 1311413004: Merge parseBorderRadius and parseInsetRoundedCorners (Closed)

Created:
5 years, 3 months ago by rwlbuis
Modified:
4 years, 11 months ago
CC:
blink-reviews, dglazkov+blink, apavlov+blink_chromium.org, blink-reviews-css, darktears
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Merge parseBorderRadius and parseInsetRoundedCorners Merge parseBorderRadius and parseInsetRoundedCorners into one method called parseRadii, since they do roughly the same thing. Since parseRadii does not add properties, do that when handling the CSSPropertyBorderRadius case. BUG=499780 Committed: https://crrev.com/9fae3fedaa0cd615de30062aed6aeec8a4051351 Cr-Commit-Position: refs/heads/master@{#368596}

Patch Set 1 #

Patch Set 2 : V2 #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase again #

Total comments: 8

Patch Set 5 : Address review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -130 lines) Patch
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h View 1 2 3 4 2 chunks +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp View 1 2 3 4 5 chunks +53 lines, -127 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
rwlbuis
PTAL. I think it is best to do this before tackling shapes.
5 years ago (2015-12-16 03:37:48 UTC) #6
rwlbuis
On 2015/12/16 03:37:48, rwlbuis wrote: > PTAL. I think it is best to do this ...
4 years, 11 months ago (2016-01-07 06:18:56 UTC) #7
Timothy Loh
ok lgtm https://codereview.chromium.org/1311413004/diff/80001/third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp File third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp (right): https://codereview.chromium.org/1311413004/diff/80001/third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp#newcode535 third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp:535: case CSSPropertyAliasWebkitBorderRadius: { btw the switch is ...
4 years, 11 months ago (2016-01-11 02:01:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311413004/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311413004/100001
4 years, 11 months ago (2016-01-11 14:44:51 UTC) #11
rwlbuis
https://codereview.chromium.org/1311413004/diff/80001/third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp File third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp (right): https://codereview.chromium.org/1311413004/diff/80001/third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp#newcode535 third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp:535: case CSSPropertyAliasWebkitBorderRadius: { On 2016/01/11 02:01:46, Timothy Loh wrote: ...
4 years, 11 months ago (2016-01-11 14:46:19 UTC) #12
commit-bot: I haz the power
Committed patchset #5 (id:100001)
4 years, 11 months ago (2016-01-11 16:03:45 UTC) #14
commit-bot: I haz the power
4 years, 11 months ago (2016-01-11 16:04:28 UTC) #16
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/9fae3fedaa0cd615de30062aed6aeec8a4051351
Cr-Commit-Position: refs/heads/master@{#368596}

Powered by Google App Engine
This is Rietveld 408576698