Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1009)

Issue 1311413003: Remove duplicate formats and types validation (Closed)

Created:
5 years, 3 months ago by qiankun
Modified:
5 years, 3 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove duplicate formats and types validation validateTexFuncFormatAndType is called twice from validateTexFuncData and validateTexFunc. This isn't necessary. BUG=295792 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201525

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -6 lines) Patch
M Source/modules/webgl/WebGLRenderingContextBase.cpp View 3 chunks +4 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
qiankun
PTAL.
5 years, 3 months ago (2015-08-31 10:02:28 UTC) #2
Zhenyao Mo
On 2015/08/31 10:02:28, qiankun wrote: > PTAL. LGTM if all conformance tests pass.
5 years, 3 months ago (2015-08-31 18:38:27 UTC) #3
Ken Russell (switch to Gerrit)
LGTM since it looks like these are the only two functions that call validateTexFuncData.
5 years, 3 months ago (2015-08-31 18:57:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311413003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311413003/1
5 years, 3 months ago (2015-09-01 02:25:38 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/101304)
5 years, 3 months ago (2015-09-01 05:42:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311413003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311413003/1
5 years, 3 months ago (2015-09-01 05:43:49 UTC) #10
commit-bot: I haz the power
5 years, 3 months ago (2015-09-01 06:50:36 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201525

Powered by Google App Engine
This is Rietveld 408576698