Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1311413002: Reland: Optimization: Make clean-up of DeviceTempFile() async (Closed)

Created:
5 years, 3 months ago by agrieve
Modified:
5 years, 3 months ago
Reviewers:
jbudorick
CC:
chromium-reviews, jbudorick+watch_chromium.org, klundberg+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@reland1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland: Optimization: Make clean-up of DeviceTempFile() async This reverts commit 7dea1d48edbfb78aefa5ee2b47d7f42827c33e27. BUG= Committed: https://crrev.com/56244390ea1e43c8ac59adde8228c0e0e5c33aae Cr-Commit-Position: refs/heads/master@{#345494}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -5 lines) Patch
M build/android/pylib/utils/device_temp_file.py View 2 chunks +12 lines, -5 lines 0 comments Download

Depends on Patchset:

Issue 1313123002 Patch 1

Messages

Total messages: 13 (4 generated)
agrieve
5 years, 3 months ago (2015-08-25 16:21:40 UTC) #2
jbudorick
This is unchanged from the original, right?
5 years, 3 months ago (2015-08-25 16:23:17 UTC) #3
agrieve
On 2015/08/25 16:23:17, jbudorick wrote: > This is unchanged from the original, right? correct
5 years, 3 months ago (2015-08-25 20:55:52 UTC) #4
jbudorick
lgtm
5 years, 3 months ago (2015-08-25 20:56:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311413002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311413002/1
5 years, 3 months ago (2015-08-25 21:36:42 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/95464)
5 years, 3 months ago (2015-08-25 22:45:17 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311413002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311413002/1
5 years, 3 months ago (2015-08-25 23:32:03 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-08-26 00:09:22 UTC) #12
commit-bot: I haz the power
5 years, 3 months ago (2015-08-26 00:10:10 UTC) #13
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/56244390ea1e43c8ac59adde8228c0e0e5c33aae
Cr-Commit-Position: refs/heads/master@{#345494}

Powered by Google App Engine
This is Rietveld 408576698