Removed archived history file deletion on browser start

Removed archived history file deletion on browser start

Remove delete of archived history file on browser start.
Archived history file usage was removed since M37.

BUG=359377
R=engedy@chromium.org

Committed: https://crrev.com/a3199711171ab3760a9b8f940f1befa2bc9f591c
Cr-Commit-Position: refs/heads/master@{#348126}

[engedy, 2015-09-08 16:07:59]

LGTM % one request: could you please also:
 -- mark the 2 corresponding diagnostic histograms in
tools/metrics/histograms/histograms.xml with the <obsolete> tag, and
 -- suffix the "SQLite Integrity Archived History Test" enumeration value in the
same file with "(obsolete)"?

This seems to have been done back then
(https://codereview.chromium.org/316063003/diff/80001/tools/metrics/histograms...),
but that patch got reverted, and apparently this part didn't make it to the
reland patch.

Thanks for cleaning this up!

[Alexander Yashkin, 2015-09-09 06:59:02]

On 2015/09/08 16:07:59, engedy wrote:
> LGTM % one request: could you please also:
>  -- mark the 2 corresponding diagnostic histograms in
> tools/metrics/histograms/histograms.xml with the <obsolete> tag, and
>  -- suffix the "SQLite Integrity Archived History Test" enumeration value in
the
> same file with "(obsolete)"?
> 
> This seems to have been done back then
>
(https://codereview.chromium.org/316063003/diff/80001/tools/metrics/histograms...),
> but that patch got reverted, and apparently this part didn't make it to the
> reland patch.
> 
> Thanks for cleaning this up!

Done.

[Alexander Yashkin, 2015-09-09 06:59:33]

The CQ bit was checked by a-v-y@yandex-team.ru

[Alexander Yashkin, 2015-09-09 06:59:33]

The patchset sent to the CQ was uploaded after l-g-t-m from engedy@chromium.org
Link to the patchset: https://codereview.chromium.org/1311403011/#ps20001
(title: "Added obsolete tag to archived history histograms")

[commit-bot: I haz the power, 2015-09-09 07:00:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1311403011/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1311403011/20001

[commit-bot: I haz the power, 2015-09-09 07:10:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-09 07:10:47]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Alexander Yashkin, 2015-09-09 07:13:47]

a-v-y@yandex-team.ru changed reviewers:
+ asvitkine@chromium.org

[Alexander Yashkin, 2015-09-09 07:15:34]

a-v-y@yandex-team.ru changed reviewers:
+ sdefresne@chromium.org

[engedy, 2015-09-09 09:30:24]

Sylvain, Alexei: It was me who originally started removing this feature, and
a-v-y has now kindly volunteered to conclude the work. The change LGTM, but I am
not an OWNER of any of the parts. Could you please take a look as OWNER of:
 -- Sylvain: components/history/
 -- Alexei: histograms.xml

Thanks!

[sdefresne, 2015-09-09 09:35:32]

components/history lgtm

[Alexei Svitkine (slow), 2015-09-09 15:08:20]

lgtm

[Alexander Yashkin, 2015-09-10 06:34:49]

The CQ bit was checked by a-v-y@yandex-team.ru

[commit-bot: I haz the power, 2015-09-10 06:34:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1311403011/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1311403011/20001

[commit-bot: I haz the power, 2015-09-10 09:26:57]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-09-10 09:27:26]

Patchset 2 (id:??) landed as
https://crrev.com/a3199711171ab3760a9b8f940f1befa2bc9f591c
Cr-Commit-Position: refs/heads/master@{#348126}

[commit-bot: I haz the power, 2015-09-23 12:09:10]

Patchset 2 (id:??) landed as
https://crrev.com/a3199711171ab3760a9b8f940f1befa2bc9f591c
Cr-Commit-Position: refs/heads/master@{#348126}