pkg/compiler/lib/src/resolution/members.dart - Issue 1311403003: dart2js cps: Track existence of try statements in resolution instead of traversing AST/IR nodes to …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/resolution/members.dart

Issue 1311403003: dart2js cps: Track existence of try statements in resolution instead of traversing AST/IR nodes to … (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« pkg/compiler/lib/src/cps_ir/type_propagation.dart ('K') | « pkg/compiler/lib/src/cps_ir/type_propagation.dart ('k') | pkg/compiler/lib/src/resolution/tree_elements.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/compiler/lib/src/resolution/members.dart

diff --git a/pkg/compiler/lib/src/resolution/members.dart b/pkg/compiler/lib/src/resolution/members.dart

index 5b7558bf9d8e2a43efcf39503ffb8b74a12573f9..c3b3461e2f7996839ec19bba273afa66ebce9e8a 100644

--- a/pkg/compiler/lib/src/resolution/members.dart

+++ b/pkg/compiler/lib/src/resolution/members.dart

@@ -4563,6 +4563,10 @@ class ResolverVisitor extends MappingVisitor<ResolutionResult> {

}

ResolutionResult visitTryStatement(TryStatement node) {

+ // TODO(karlklose): also track the information about mutated variables, catch, and

Kevin Millikin (Google) 2015/09/07 09:11:17 I guess that's a long line.

+ // finally-block.

+ elements.hasTryStatement = true;

visit(node.tryBlock);

if (node.catchBlocks.isEmpty && node.finallyBlock == null) {

error(node.getEndToken().next, MessageKind.NO_CATCH_NOR_FINALLY);