Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(978)

Issue 1311373002: Make WebSubstringUtil to use EphemeralRange instead of Range (Closed)

Created:
5 years, 4 months ago by yosin_UTC9
Modified:
5 years, 4 months ago
Reviewers:
tkent, keishi
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Make WebSubstringUtil to use EphemeralRange instead of Range This patch changes |WebSubstringUtil| class to use |EphemeralRange| instead of |Range| object to avoid registering temporary |Range| object into |Document| for Oilpan friendly. This patch is also a preparation of making selection to handle granularity for web component, http://crrev.com/1277863002 to reduce DOM position dependency from |VisibleSelection| for ease of templatization of |VisibleSelection|. BUG=388681, 513568 TEST=n/a; no behavior changes Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201120

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M Source/web/mac/WebSubstringUtil.mm View 3 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
yosin_UTC9
PTAL
5 years, 4 months ago (2015-08-25 09:05:19 UTC) #3
tkent
lgtm
5 years, 4 months ago (2015-08-25 09:15:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311373002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311373002/1
5 years, 4 months ago (2015-08-25 09:20:02 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-25 10:20:04 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201120

Powered by Google App Engine
This is Rietveld 408576698