Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 1311363003: Revert of Array.prototype.unshift builtin improvements (Closed)

Created:
5 years, 4 months ago by Camillo Bruni
Modified:
5 years, 4 months ago
Reviewers:
Yang, Michael Hablich
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Array.prototype.unshift builtin improvements (patchset #3 id:40001 of https://codereview.chromium.org/1311343002/ ) Reason for revert: https://codereview.chromium.org/1315823004/ Original issue's description: > Array.prototype.unshift builtin improvements > > Moving unshift to ElementAccessor and increasing the range of arguments > handled directly in C++, namely directly supporting FastDoubleElementsKind. > This should yield a factor 19 speedup for unshift on fast double arrays. > > BUG= > > Committed: https://crrev.com/bf6764e6c1197e50ae148755488307a423b1d9b4 > Cr-Commit-Position: refs/heads/master@{#30347} TBR=yangguo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/12ad2554fb60d6407686025066616938cb670088 Cr-Commit-Position: refs/heads/master@{#30350}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -75 lines) Patch
M src/builtins.cc View 6 chunks +44 lines, -8 lines 0 comments Download
M src/elements.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/elements.cc View 4 chunks +15 lines, -63 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Camillo Bruni
Created Revert of Array.prototype.unshift builtin improvements
5 years, 4 months ago (2015-08-25 11:11:08 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311363003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311363003/1
5 years, 4 months ago (2015-08-25 11:11:14 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-25 11:11:22 UTC) #3
commit-bot: I haz the power
5 years, 4 months ago (2015-08-25 11:11:39 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/12ad2554fb60d6407686025066616938cb670088
Cr-Commit-Position: refs/heads/master@{#30350}

Powered by Google App Engine
This is Rietveld 408576698