Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: pkg/compiler/lib/src/cps_ir/cps_ir_nodes_sexpr.dart

Issue 1311353008: dart2js cps: Use a strictness flag on Branch instead of rewriting. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart ('k') | pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/cps_ir/cps_ir_nodes_sexpr.dart
diff --git a/pkg/compiler/lib/src/cps_ir/cps_ir_nodes_sexpr.dart b/pkg/compiler/lib/src/cps_ir/cps_ir_nodes_sexpr.dart
index a04fb4eb5d170003055ba4d5d5961cfb0a0ed469..988ee694ade8b9fc08beb11167b7ad0b2d7c9368 100644
--- a/pkg/compiler/lib/src/cps_ir/cps_ir_nodes_sexpr.dart
+++ b/pkg/compiler/lib/src/cps_ir/cps_ir_nodes_sexpr.dart
@@ -192,10 +192,11 @@ class SExpressionStringifier extends Indentation implements Visitor<String> {
}
String visitBranch(Branch node) {
- String condition = visit(node.condition);
+ String condition = access(node.condition);
String trueCont = access(node.trueContinuation);
String falseCont = access(node.falseContinuation);
- return '$indentation(Branch $condition $trueCont $falseCont)';
+ String strict = node.isStrictCheck ? 'Strict' : 'NonStrict';
+ return '$indentation(Branch $condition $trueCont $falseCont $strict)';
}
String visitUnreachable(Unreachable node) {
@@ -251,11 +252,6 @@ class SExpressionStringifier extends Indentation implements Visitor<String> {
return '(LiteralMap ($keys) ($values))';
}
- String visitIsTrue(IsTrue node) {
- String value = access(node.value);
- return '(IsTrue $value)';
- }
-
String visitSetField(SetField node) {
String object = access(node.object);
String field = node.field.name;
« no previous file with comments | « pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart ('k') | pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698