Adds a way to determine id of content handler that created app

mojo/shell/content_handler_connection.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef MOJO_SHELL_CONTENT_HANDLER_CONNECTION_H_
 #define MOJO_SHELL_CONTENT_HANDLER_CONNECTION_H_
 
 #include <string>
 
+#include "base/memory/weak_ptr.h"
 #include "mojo/application/public/interfaces/content_handler.mojom.h"
+#include "mojo/application/public/interfaces/shell.mojom.h"
 #include "mojo/shell/capability_filter.h"
 #include "url/gurl.h"
 
 namespace mojo {
 namespace shell {
 
 class ApplicationInstance;
 class ApplicationManager;
 
 // A ContentHandlerConnection is responsible for creating and maintaining a
 // connection to an app which provides the ContentHandler service.
 // A ContentHandlerConnection can only be destroyed via CloseConnection.
 // A ContentHandlerConnection manages its own lifetime and cannot be used with
 // a scoped_ptr to avoid reentrant calls into ApplicationManager late in
 // destruction.
 class ContentHandlerConnection {
  public:
+  // |id| is a unique identifier for this content handler.
   ContentHandlerConnection(ApplicationInstance* originator,
                            ApplicationManager* manager,
                            const GURL& content_handler_url,
                            const GURL& requestor_url,
                            const std::string& qualifier,
-                           const CapabilityFilter& filter);
+                           const CapabilityFilter& filter,
+                           uint32_t id);
 
   // Closes the connection and destroys |this| object.
   void CloseConnection();
 
   ContentHandler* content_handler() { return content_handler_.get(); }
   const GURL& content_handler_url() { return content_handler_url_; }
   const std::string& content_handler_qualifier() {
     return content_handler_qualifier_;
   }
+  uint32_t id() const { return id_; }
+
+  // Schedules a callback to be run once the id of any nested content handlers
+  // are obtained.
+  void ScheduleTargetIdCallback(

[Ben Goodger (Google), 2015/08/31 17:41:07]

rename?

[sky, 2015/08/31 19:46:07]

This was all nuked.

+      const Shell::ConnectToApplicationCallback& connect_callback);
 
  private:
   ~ContentHandlerConnection();
 
+  // Callback from ConnectToApplication() on the target application.
+  void OnGotNestedContentHandlerID(uint32_t content_handler_id);
+
+  // Returns the id to supply to the callback from
+  // Shell::ConnectToApplication(). The returned id is either the id of this
+  // content handler, or if connecting to the application involved another
+  // content handler, then the deepest id from that connection.
+  //
+  // This is only valid once OnGotNestedContentHandlerID() is received.
+  uint32_t content_handler_id_for_callback() const;
+
   ApplicationManager* manager_;
   GURL content_handler_url_;
   std::string content_handler_qualifier_;
   ContentHandlerPtr content_handler_;
   bool connection_closed_;
+  // The id for this content handler.
+  const uint32_t id_;
+
+  // Set to true once OnGotNestedContentHandlerID() has been invoked. At this
+  // point |nested_content_handler_id_| is valid.
+  bool got_nested_content_handler_id_;
+  uint32_t nested_content_handler_id_;
+
+  // Callbacks scheduled before OnGotNestedContentHandlerID() are added here.
+  // Once OnGotNestedContentHandlerID() is called these are processed.
+  std::vector<Shell::ConnectToApplicationCallback>
+      pending_content_handler_id_callbacks_;
+
+  base::WeakPtrFactory<ContentHandlerConnection> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(ContentHandlerConnection);
 };
 
 }  // namespace shell
 }  // namespace mojo
 
 #endif  // MOJO_SHELL_CONTENT_HANDLER_CONNECTION_H_