Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(539)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1311343007: Add DevTools method for cross-process memory notification suppressing (Closed)

Created:
5 years, 3 months ago by petrcermak
Modified:
5 years, 3 months ago
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add DevTools method for cross-process memory notification suppressing This patch is the second part of a 3-sided patch which adds Memory.setPressureNotificationsSuppressed method to DevTools API: 1. Add DevTools method for cross-process memory notification suppressing https://codereview.chromium.org/1336363002/ [Chromium] 2. Add DevTools method for cross-process memory notification suppressing (this patch) [Blink] 3. Enable DevTools method for cross-process memory notification suppressing https://codereview.chromium.org/1342833004/ [Chromium] Proposal: https://goo.gl/cZFdH3 BUG=516776

Patch Set 1 #

Total comments: 2

Patch Set 2 : Update for review feedback #

Patch Set 3 : Remove asynchronous callback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M Source/devtools/protocol.json View 1 2 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Sami
https://codereview.chromium.org/1311343007/diff/1/Source/devtools/protocol.json File Source/devtools/protocol.json (right): https://codereview.chromium.org/1311343007/diff/1/Source/devtools/protocol.json#newcode61 Source/devtools/protocol.json:61: "name": "setNotificationsSuppressed", nit: "Notifications" sounds a little too general. ...
5 years, 3 months ago (2015-09-08 17:43:28 UTC) #2
petrcermak
Thanks for your comments. PTAL. Petr https://codereview.chromium.org/1311343007/diff/1/Source/devtools/protocol.json File Source/devtools/protocol.json (right): https://codereview.chromium.org/1311343007/diff/1/Source/devtools/protocol.json#newcode61 Source/devtools/protocol.json:61: "name": "setNotificationsSuppressed", On ...
5 years, 3 months ago (2015-09-14 12:46:03 UTC) #4
Sami
Non-owner lgtm.
5 years, 3 months ago (2015-09-14 13:48:09 UTC) #5
Primiano Tucci (use gerrit)
On 2015/09/14 13:48:09, Sami wrote: > Non-owner lgtm. LGTM (still non-owner)
5 years, 3 months ago (2015-09-15 09:57:59 UTC) #6
petrcermak
pfeldman: Hi, please review this small patch. Thanks, Petr
5 years, 3 months ago (2015-09-17 16:15:23 UTC) #8
pfeldman
lgtm
5 years, 3 months ago (2015-09-17 19:13:00 UTC) #9
petrcermak
This patch was merged into https://codereview.chromium.org/1336363002/ after the Blink merge.
5 years, 3 months ago (2015-09-24 13:19:59 UTC) #10
Primiano Tucci (use gerrit)
5 years, 3 months ago (2015-09-24 15:07:20 UTC) #11
Message was sent while issue was closed. 
On 2015/09/24 13:19:59, petrcermak wrote:
> This patch was merged into https://codereview.chromium.org/1336363002/ after
the
> Blink merge.

My vigilant CDO observes and approves the accurate tracking of CL status. :)

Powered by Google App Engine
This is Rietveld 408576698