Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 1311343002: Array.prototype.unshift builtin improvements (Closed)

Created:
5 years, 4 months ago by Camillo Bruni
Modified:
5 years, 3 months ago
Reviewers:
Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Array.prototype.unshift builtin improvements Moving unshift to ElementAccessor and increasing the range of arguments handled directly in C++, namely directly supporting FastDoubleElementsKind. This should yield a factor 19 speedup for unshift on fast double arrays. BUG= Committed: https://crrev.com/bf6764e6c1197e50ae148755488307a423b1d9b4 Cr-Commit-Position: refs/heads/master@{#30347}

Patch Set 1 #

Patch Set 2 : signed compare fix #

Patch Set 3 : signedness #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -58 lines) Patch
M src/builtins.cc View 6 chunks +7 lines, -43 lines 0 comments Download
M src/elements.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/elements.cc View 1 2 4 chunks +63 lines, -15 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311343002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311343002/1
5 years, 4 months ago (2015-08-25 07:13:29 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/5177) v8_win_compile_dbg on ...
5 years, 4 months ago (2015-08-25 07:15:01 UTC) #4
Camillo Bruni
PTAL
5 years, 4 months ago (2015-08-25 08:29:53 UTC) #6
Yang
On 2015/08/25 08:29:53, cbruni wrote: > PTAL lgtm.
5 years, 4 months ago (2015-08-25 09:04:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311343002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311343002/40001
5 years, 4 months ago (2015-08-25 09:18:40 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 4 months ago (2015-08-25 09:45:29 UTC) #10
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/bf6764e6c1197e50ae148755488307a423b1d9b4 Cr-Commit-Position: refs/heads/master@{#30347}
5 years, 4 months ago (2015-08-25 09:45:48 UTC) #11
Camillo Bruni
5 years, 4 months ago (2015-08-25 11:11:08 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1311363003/ by cbruni@chromium.org.

The reason for reverting is: https://codereview.chromium.org/1315823004/.

Powered by Google App Engine
This is Rietveld 408576698