Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 1311333005: Disable material design downloads UI from some tests. (Closed)

Created:
5 years, 3 months ago by benwells
Modified:
5 years, 3 months ago
Reviewers:
Lei Zhang, Dan Beam
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable material design downloads UI from some tests. The new material design downloads UI is very slow, and causes some tests to timeout on memory bots. BUG=526577 Committed: https://crrev.com/f3c6fac098f72b9d3d9f92494439b00656f1a4e9 Cr-Commit-Position: refs/heads/master@{#346785}

Patch Set 1 #

Total comments: 3

Patch Set 2 : Feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -4 lines) Patch
M chrome/browser/lifetime/browser_close_manager_browsertest.cc View 1 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/ui/browser_browsertest.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/browser_navigator_browsertest.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/find_bar/find_bar_host_browsertest.cc View 1 3 chunks +9 lines, -0 lines 0 comments Download
M chrome/test/base/web_ui_browser_test_browsertest.cc View 1 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
benwells
https://codereview.chromium.org/1311333005/diff/1/chrome/browser/ui/browser_browsertest.cc File chrome/browser/ui/browser_browsertest.cc (left): https://codereview.chromium.org/1311333005/diff/1/chrome/browser/ui/browser_browsertest.cc#oldcode1346 chrome/browser/ui/browser_browsertest.cc:1346: EXPECT_FALSE(command_updater->IsCommandEnabled(IDC_CREATE_SHORTCUTS)); The case this is testing is covered by ...
5 years, 3 months ago (2015-09-01 20:35:22 UTC) #2
Dan Beam
lgtm
5 years, 3 months ago (2015-09-01 20:41:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311333005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311333005/1
5 years, 3 months ago (2015-09-01 22:03:08 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/95401)
5 years, 3 months ago (2015-09-01 22:13:33 UTC) #7
benwells
oops... +thestig for owner
5 years, 3 months ago (2015-09-01 22:33:13 UTC) #9
Lei Zhang
lgtm https://codereview.chromium.org/1311333005/diff/1/chrome/test/base/web_ui_browser_test_browsertest.cc File chrome/test/base/web_ui_browser_test_browsertest.cc (right): https://codereview.chromium.org/1311333005/diff/1/chrome/test/base/web_ui_browser_test_browsertest.cc#newcode34 chrome/test/base/web_ui_browser_test_browsertest.cc:34: // Disable new downloads UI as it is ...
5 years, 3 months ago (2015-09-01 22:41:07 UTC) #10
benwells
https://codereview.chromium.org/1311333005/diff/1/chrome/test/base/web_ui_browser_test_browsertest.cc File chrome/test/base/web_ui_browser_test_browsertest.cc (right): https://codereview.chromium.org/1311333005/diff/1/chrome/test/base/web_ui_browser_test_browsertest.cc#newcode34 chrome/test/base/web_ui_browser_test_browsertest.cc:34: // Disable new downloads UI as it is very ...
5 years, 3 months ago (2015-09-01 23:06:11 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311333005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311333005/20001
5 years, 3 months ago (2015-09-01 23:06:43 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-01 23:38:58 UTC) #15
commit-bot: I haz the power
5 years, 3 months ago (2015-09-01 23:39:38 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f3c6fac098f72b9d3d9f92494439b00656f1a4e9
Cr-Commit-Position: refs/heads/master@{#346785}

Powered by Google App Engine
This is Rietveld 408576698