Issue 1311333003: Don't spawn debugger.mojo by default in `mojo_run`.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1311333003: Don't spawn debugger.mojo by default in `mojo_run`. (Closed)

Created:
5 years, 3 months ago by ppi

Modified:
5 years, 3 months ago

Reviewers:
qsr (NOT THE RIGHT qsr), qsr

CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Don't spawn debugger.mojo by default in `mojo_run`. This patch replaces `--no-debugger` switch in `mojo_run` with `--debugger`, flipping the default to default to running without debugger. Motivation: simplest actions should be accomplished through simplest command lines. We should not need to remember to pass `--no-debugger` to ensure that shell terminates. Fixes domokit/devtools#40. R=qsr@google.com, qsr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/708fe8794cc177b08d477f38dbd1f6ee4ebe4dc0

Patch Set 1 #

Patch Set 2 : #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -10 lines)			Patch
M	mojo/devtools/common/README.md	View	1	1 chunk	+9 lines, -2 lines	0 comments	Download
M	mojo/devtools/common/mojo_debug	View	1	3 chunks	+7 lines, -3 lines	0 comments	Download
M	mojo/devtools/common/mojo_run	View		4 chunks	+6 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

ppi

5 years, 3 months ago (2015-08-31 12:48:28 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
708fe8794cc177b08d477f38dbd1f6ee4ebe4dc0 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages