Source/core/rendering/RenderBlock.cpp - Issue 131133004: [CSS Shapes] Dynamically created element with image valued shape-outside doesn't update

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderBlock.cpp

Issue 131133004: [CSS Shapes] Dynamically created element with image valued shape-outside doesn't update (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Removed unnecessary frameView() check Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/shapes/shape-outside-floats/shape-outside-insert-svg-shape-expected.html ('k') | Source/core/rendering/RenderBox.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/RenderBlock.cpp

diff --git a/Source/core/rendering/RenderBlock.cpp b/Source/core/rendering/RenderBlock.cpp

index 6eec95fcc9a3d75a9217179e9ec19b42302478a8..a53ecc657448f8f74c412e26aa97859b92ed958e 100644

--- a/Source/core/rendering/RenderBlock.cpp

+++ b/Source/core/rendering/RenderBlock.cpp

@@ -1407,10 +1407,6 @@ void RenderBlock::imageChanged(WrappedImagePtr image, const IntRect*)

shapeInsideInfo->dirtyShapeSize();

markShapeInsideDescendantsForLayout();

}

- ShapeValue* shapeOutsideValue = style()->shapeOutside();

- if (isFloating() && shapeOutsideValue && shapeOutsideValue->image() && shapeOutsideValue->image()->data() == image)

- parent()->setNeedsLayoutAndPrefWidthsRecalc();

}

void RenderBlock::updateShapeInsideInfoAfterStyleChange(const ShapeValue* shapeInside, const ShapeValue* oldShapeInside)