components/nacl/loader/nonsfi/abi_conversion.h - Issue 131133002: Implement nacl_irt_fdio for non-sfi mode.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/nacl/loader/nonsfi/abi_conversion.h

Issue 131133002: Implement nacl_irt_fdio for non-sfi mode. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2014 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4
	Mark Seaborn 2014/01/10 13:11:20 This file should use the standard #ifndef+#define This file should use the standard #ifndef+#define include guard, so that no-one gets a surprise if they add non-idempotent declarations to it hidehiko 2014/01/15 03:50:44 Oops. Good catch. Fixed. Show quoted text On 2014/01/10 13:11:20, Mark Seaborn wrote: > This file should use the standard #ifndef+#define include guard, so that no-one > gets a surprise if they add non-idempotent declarations to it Oops. Good catch. Fixed.
	5 extern "C" {
	Mark Seaborn 2014/01/10 13:11:20 'extern "C"' doesn't affect struct declarations, s 'extern "C"' doesn't affect struct declarations, so you can remove this hidehiko 2014/01/15 03:50:44 Done. Show quoted text On 2014/01/10 13:11:20, Mark Seaborn wrote: > 'extern "C"' doesn't affect struct declarations, so you can remove this Done.
	6 struct stat;

	7 struct nacl_abi_stat;

	8 }

	9

	10 namespace nacl {

	11 namespace nonsfi {

	12

	13 // Converts the stat struct from host's to NaCl's ABI.

	14 void StatToNaClAbiStat(

	15 const struct stat& host_stat, struct nacl_abi_stat* nacl_stat);

	16

	17 } // namespace nonsfi

	18 } // namespace nacl

OLD	NEW