Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(516)

Issue 1311263003: Switch breakpad DEPS to new Git repo URL. (Closed)

Created:
5 years, 4 months ago by Vadim Sh.
Modified:
5 years, 3 months ago
CC:
chromium-reviews, Primiano Tucci (use gerrit)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Switch breakpad DEPS to new Git repo URL. Breakpad is migrating to Git, and we won't be able to git-svn-export its src/ directory. Instead we'll be using gsubtreed service to extract src/* subtree from breakpad/breakpad git repo into breakpad/breakpad/src repo. This CL changes DEPs to use new repo (at the same commit). Git hashes are different because gsubtreed produces commit messages that are different from git-svn exporter. BUG=502355 R=primiano@chromium.org,ivanpe@chromium.org Committed: https://crrev.com/121df6f5c96daeeb186ff59eaaff58b1a3397ae7 Cr-Commit-Position: refs/heads/master@{#346724}

Patch Set 1 #

Total comments: 3

Patch Set 2 : remove "from svn revision" #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (6 generated)
Vadim Sh.
PTAL Previously referenced commit: https://chromium.googlesource.com/external/google-breakpad/src/+/e100989d3776aa1a6bfa9453edca227a679e3a0c New commit: https://chromium.googlesource.com/breakpad/breakpad/src/+/00915090d0511189d2d41818cbf617e7cc1426f9 Generated by this cron-like builder (running continuously): ...
5 years, 4 months ago (2015-08-24 22:23:22 UTC) #1
Primiano Tucci (use gerrit)
+mark, make sure that he is onboard with the plan here. https://codereview.chromium.org/1311263003/diff/1/DEPS File DEPS (right): ...
5 years, 4 months ago (2015-08-24 22:51:21 UTC) #3
Vadim Sh.
On 2015/08/24 22:51:21, Primiano Tucci wrote: > +mark, make sure that he is onboard with ...
5 years, 4 months ago (2015-08-24 22:54:20 UTC) #4
Vadim Sh.
ping
5 years, 3 months ago (2015-09-01 18:00:56 UTC) #6
Michael Moss
lgtm
5 years, 3 months ago (2015-09-01 18:03:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311263003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311263003/1
5 years, 3 months ago (2015-09-01 18:13:20 UTC) #9
Mark Mentovai
LGTM otherwise https://codereview.chromium.org/1311263003/diff/1/DEPS File DEPS (right): https://codereview.chromium.org/1311263003/diff/1/DEPS#newcode100 DEPS:100: Var('chromium_git') + '/breakpad/breakpad/src.git' + '@' + '00915090d0511189d2d41818cbf617e7cc1426f9', ...
5 years, 3 months ago (2015-09-01 19:05:02 UTC) #10
Mark Mentovai
What is gclient’s behavior when moving a repository like this?
5 years, 3 months ago (2015-09-01 19:05:16 UTC) #11
Vadim Sh.
On 2015/09/01 19:05:16, Mark Mentovai - August is over wrote: > What is gclient’s behavior ...
5 years, 3 months ago (2015-09-01 19:09:14 UTC) #13
Vadim Sh.
https://codereview.chromium.org/1311263003/diff/1/DEPS File DEPS (right): https://codereview.chromium.org/1311263003/diff/1/DEPS#newcode100 DEPS:100: Var('chromium_git') + '/breakpad/breakpad/src.git' + '@' + '00915090d0511189d2d41818cbf617e7cc1426f9', # from ...
5 years, 3 months ago (2015-09-01 19:11:39 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311263003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311263003/20001
5 years, 3 months ago (2015-09-01 19:12:05 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-01 20:32:06 UTC) #18
commit-bot: I haz the power
5 years, 3 months ago (2015-09-01 20:32:33 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/121df6f5c96daeeb186ff59eaaff58b1a3397ae7
Cr-Commit-Position: refs/heads/master@{#346724}

Powered by Google App Engine
This is Rietveld 408576698