Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Issue 1311233004: Cleanup IsKeyPad and IsAutoRepeat in PlatformKeyboardEvent (Closed)

Created:
5 years, 4 months ago by dtapuska
Modified:
5 years, 3 months ago
Reviewers:
tkent
CC:
blink-reviews, blink-reviews-events_chromium.org, dglazkov+blink, eae+blinkwatch
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Cleanup IsKeyPad and IsAutoRepeat in PlatformKeyboardEvent Switch keypad and auto repeat booleans to use enum flags. Space was reserved for them; this just brings PlatformKeyboardEvent more inline with WebInputEvent. BUG=524626 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201258

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -14 lines) Patch
M Source/platform/PlatformEvent.h View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/platform/PlatformKeyboardEvent.h View 4 chunks +3 lines, -9 lines 0 comments Download
M Source/web/WebInputEventConversion.cpp View 2 chunks +11 lines, -3 lines 0 comments Download
M Source/web/tests/WebPluginContainerTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 22 (10 generated)
dtapuska
5 years, 4 months ago (2015-08-25 19:45:50 UTC) #2
tkent
lgtm
5 years, 3 months ago (2015-08-25 23:28:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311233004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311233004/1
5 years, 3 months ago (2015-08-25 23:29:33 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/95541)
5 years, 3 months ago (2015-08-26 01:52:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311233004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311233004/1
5 years, 3 months ago (2015-08-26 13:46:38 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/95821)
5 years, 3 months ago (2015-08-26 15:57:31 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311233004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311233004/1
5 years, 3 months ago (2015-08-26 16:02:04 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/95896)
5 years, 3 months ago (2015-08-26 17:00:14 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311233004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311233004/1
5 years, 3 months ago (2015-08-26 17:11:54 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/95938)
5 years, 3 months ago (2015-08-26 18:06:53 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311233004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311233004/1
5 years, 3 months ago (2015-08-26 19:35:21 UTC) #21
commit-bot: I haz the power
5 years, 3 months ago (2015-08-26 22:50:15 UTC) #22
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201258

Powered by Google App Engine
This is Rietveld 408576698