roll skia DEPS to 13107

roll skia DEPS to 13107

Chromium base revision: 244998 / a10bed42
Old Skia revision: 13077
New Skia revision: 13107
Control CL: https://codereview.chromium.org/140193002

This CL was created by Skia's roll_deps.py script.

R=bsalomon@google.com

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245246

[robertphillips, 2014-01-16 12:42:34]

This roll is blocked on webkit_unit_test failures:

android_dbg
   roll:    
            slave_steps 
            webkit_unit_tests 

Currently running:
ImageDecodingStoreTest.insertGenerationCollisionAfterMemoryDiscarded
ImageDecodingStoreTest.lockCacheFailedAfterMemoryDiscarded:
[FATAL:SkBitmap.cpp(1604)] ../../third_party/skia/src/core/SkBitmap.cpp:1604:
failed assertion "fPixelRef->rowBytes() == fRowBytes"

   control: 
            green

linux
   roll:    
            buildrunner_tests 
            interactive_ui_tests 255 disabled failed 133 
                ...
            cc_unittests 4 disabled 11 flaky failed 11
                ResourcelessSoftwareDrawAfterResourceLoss
                RunMultiThread_DelegatingRenderer_ImplSidePaint
                RunMultiThread_DelegatingRenderer_MainThreadPaint
                RunMultiThread_DirectRenderer_ImplSidePaint
                RunMultiThread_DirectRenderer_MainThreadPaint
                RunMultiThread_DelegatingRenderer_ImplSidePaint
                RunMultiThread_DelegatingRenderer_MainThreadPaint
                RunMultiThread_DirectRenderer_ImplSidePaint
                RunMultiThread_DirectRenderer_MainThreadPaint
                RunSingleThread_DelegatingRenderer
                RunSingleThread_DirectRenderer
            unit_tests 51 disabled 53 flaky failed 51 
                ...
            ui_unittests 1 disabled 17 flaky failed 17 
                ...
            content_unittests 17 disabled 6 flaky failed 6
                ...
            browser_tests 327 disabled failed 2795 
                ...
            content_browsertests 23 disabled failed 50 
                ...
            nacl_integration 
   control: 
            green

linux_gpu
   roll:    
            running steps via annotated script 
            maps_pixel_test did not complete failed 1
            pixel_test did not complete failed 1
            webgl_conformance_tests did not complete failed 1
            context_lost_tests did not complete failed 1
            memory_test did not complete failed 1
            hardware_accelerated_feature_tests did not complete 
            gpu_process_launch_tests did not complete failed 1
   control: 
            green

mac
   roll:    
            buildrunner_tests 
            webkit_unit_tests crashed or hung 

SkBitmap::validate() const + 1076
SkBitmap::lockPixels() const + 127
WebCore::ImageDecodingStore::insertAndLockCache(WebCore::ImageFrameGenerator
const*, WTF::PassOwnPtr<WebCore::ScaledImageFragment>) + 550

   control: 
            buildrunner_tests 
            telemetry_unittests failed 2
                testMultipleTabCalls
                testBasicHostingAndRangeRequests

mac_asan
   roll:    
            buildrunner_tests 
            telemetry_unittests failed 4
                testCommandLineOverriding ***************************
                testMultipleTabCalls
                testRuntimeEvaluateOfSomethingThatCantJSONize *******
                testBasicHostingAndRangeRequests
            unit_tests crashed or hung 
   control: 
            buildrunner_tests 
            telemetry_unittests failed 3
                testMultipleTabCalls
                testFailure
                testBasicHostingAndRangeRequests
            unit_tests crashed or hung 
            browser_tests 340 disabled 41 flaky failed 1
                TestIsSearchProviderInstalled

win
   roll:    
            buildrunner_tests 
            telemetry_unittests failed 2
                testMultipleTabCalls ***********************************
                testBasicHostingAndRangeRequests ***********************
            content_browsertests 56 disabled 6 flaky failed 1
                 LimitTotal ********************************************
            webkit_unit_tests crashed or hung **************************
   control: 
            green

linux_layout
   roll:    
            webkit_tests ?? fixable (0 skipped) crashed or hung 
            buildrunner_tests 
            webkit_unit_tests crashed or hung
   control: 
            gclient_revert failed
            update r244998 failed 

linux_layout_rel
   roll:    
            gclient_revert failed 
            update r244998 failed 
   control: 
            green

mac_layout
   roll:    
            webkit_tests 762 fixable (0 skipped) failed 1
                encrypted-media-needkey.html 
            buildrunner_tests 
            webkit_unit_tests crashed or hung *********************
   control: 
            webkit_tests 765 fixable (0 skipped) failed 1
                encrypted-media-needkey.html 

win_layout
   roll:    
            webkit_tests 307 fixable (0 skipped) failed 2
                encrypted-media-needkey.html 
                use-while-animating-crash.html 
            buildrunner_tests
                webkit_unit_tests crashed or hung 
   control: 
            compile failed

win_layout_rel
   roll:    
            webkit_tests 247 fixable (0 skipped) failed 2
                heap-snapshot-summary-show-ranges.html 
                online-whitelist.html 
   control: 
            green

[f(malita), 2014-01-16 14:10:50]

I'm also hitting that assert with a debug ToT Chromium build this morning:

[14043:14043:0116/140941:FATAL:SkBitmap.cpp(1604)]
../../third_party/skia/src/core/SkBitmap.cpp:1604: failed assertion
"fPixelRef->rowBytes() == fRowBytes"

 [0x7f638daac78e] base::debug::StackTrace::StackTrace()
 [0x7f638db2e7a5] logging::LogMessage::~LogMessage()
 [0x7f638e4d0211] SkDebugf_FileLine()
 [0x7f638e2ba66d] SkBitmap::validate()
 [0x7f638e2bbee1] SkBitmap::lockPixels()
 [0x7f638e2c2e94] SkBitmapDevice::lockPixels()
 [0x7f638e29eef7] SkBaseDevice::onAttachToCanvas()
 [0x7f638e301d57] SkCanvas::setDevice()
 [0x7f638e3011c0] SkCanvas::init()
 [0x7f638e3012f5] SkCanvas::SkCanvas()
 [0x7f638e4d9986] skia::CreateCanvas()
 [0x7f638e4c21a2] skia::CreatePlatformCanvas()
 [0x7f638c431878] skia::CreatePlatformCanvas()
 [0x7f638c4317bb] gfx::Canvas::Canvas()
 [0x7f638c4538f2] gfx::internal::ImageSkiaFromGdkPixbuf()
 [0x7f638c454c52] gfx::Image::ToImageSkia()
 [0x7f638c454af5] gfx::Image::ToSkBitmap()
 [0x7f638c4559ab] gfx::Image::AsBitmap()
 [0x0000021bd38a] TabStripGtk::SetNewTabButtonBackground()
 [0x0000021bd2e7] TabStripGtk::Observe()
 [0x0000021bd47d] TabStripGtk::Observe()
 [0x00000214c1e2] GtkThemeService::InitThemesFor()
 [0x0000021b920e] TabStripGtk::Init()
 [0x00000210d414] BrowserWindowGtk::InitWidgets()
 [0x00000210d01f] BrowserWindowGtk::Init()
 [0x000002115c9f] BrowserWindow::CreateBrowserWindow()
 [0x0000020c3305] (anonymous namespace)::CreateBrowserWindow()
 [0x0000020c2ea2] Browser::Browser()
 [0x0000022457b8] StartupBrowserCreatorImpl::OpenTabsInBrowser()
 [0x0000022448ba] StartupBrowserCreatorImpl::ProcessSpecifiedURLs()
 [0x0000022444c1] StartupBrowserCreatorImpl::ProcessStartupURLs()
 [0x0000022432dc] StartupBrowserCreatorImpl::ProcessLaunchURLs()
 [0x000002242a8e] StartupBrowserCreatorImpl::Launch()
 [0x00000223b685] StartupBrowserCreator::LaunchBrowser()
 [0x00000223d430] StartupBrowserCreator::ProcessCmdLineImpl()
 [0x000000fb29cb] StartupBrowserCreator::Start()
 [0x000000fafb6b] ChromeBrowserMainParts::PreMainMessageLoopRunImpl()
 [0x000000fae88e] ChromeBrowserMainParts::PreMainMessageLoopRun()
 [0x7f6386600572] content::BrowserMainLoop::PreMainMessageLoopRun()
 [0x7f6386607152] base::internal::RunnableAdapter<>::Run()
 [0x7f63866070cc] base::internal::InvokeHelper<>::MakeItSo()
 [0x7f638660709a] base::internal::Invoker<>::Run()
 [0x7f6386a5bfce] base::Callback<>::Run()
 [0x7f6386d511fb] content::StartupTaskRunner::RunAllTasksNow()
 [0x7f63865fee9c] content::BrowserMainLoop::CreateStartupTasks()
 [0x7f6386609eee] content::BrowserMainRunnerImpl::Initialize()
 [0x7f63865fb5c5] content::BrowserMain()
 [0x7f638659fd8f] content::RunNamedProcessTypeMain()
 [0x7f63865a294d] content::ContentMainRunnerImpl::Run()
 [0x7f638659f2e4] content::ContentMain()
 [0x0000004e0bce] ChromeMain
 [0x0000004e0b87] main
 [0x7f637ab6976d] __libc_start_main
 [0x0000004e0a99] <unknown>

[robertphillips, 2014-01-16 14:49:56]

Here are the CLs in this roll:

https://code.google.com/p/skia/source/list?num=26&start=13103

The proximal cause is: 

r13093 - add asserts to validate - https://codereview.chromium.org/139063003

But it looks like reverting that would be curing the symptom not the disease.

Hal - any ideas?

[robertphillips, 2014-01-16 17:16:02]

This seems good enough to roll.

[bsalomon, 2014-01-16 18:02:27]

On 2014/01/16 17:16:02, robertphillips wrote:
> This seems good enough to roll.

lgtm

[robertphillips, 2014-01-16 18:03:46]

Committed patchset #2 manually as r245246 (presubmit successful).