Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(920)

Issue 1311163004: [tracing] Re-enable mmaps dump provider for memory-infra (Closed)

Created:
5 years, 3 months ago by Primiano Tucci (use gerrit)
Modified:
5 years, 3 months ago
Reviewers:
dsinclair, jschuh, mdempsky
CC:
chromium-reviews, tracing+reviews_chromium.org, wfh+watch_chromium.org, ssid, sullivan, petrcermak, picksi1, dsinclair, nduca
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[tracing] Re-enable mmaps dump provider for memory-infra As agreed during the offline meeting, it is OK for chrome://tracing to get mmaps dumps into the trace data, as long as the infobar indicating that an extension with the debugger permission is using the devtools protocol is showed on all tabs. The latter happened in crrev.com/1295493005 (see crbug.com/521686), so this is effectively a revert of crrev.com/1275013005. BUG=517906 Committed: https://crrev.com/c3e3255edf63003a1e559f50fe7f51325ce2051d Cr-Commit-Position: refs/heads/master@{#347201}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -8 lines) Patch
M base/trace_event/memory_dump_manager.cc View 1 chunk +1 line, -8 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
Primiano Tucci (use gerrit)
mdempsky/jschuh this is a follow-up to our meeting 2015-08-14 "Chrome Memory Dumping security issues". As ...
5 years, 3 months ago (2015-09-01 14:01:04 UTC) #2
mdempsky
LGTM I skimmed the crbug.com/521686 and crrev.com/1295493005, and I agree they look to have implemented ...
5 years, 3 months ago (2015-09-01 20:35:36 UTC) #3
Primiano Tucci (use gerrit)
+nduca for pre-flight stamp
5 years, 3 months ago (2015-09-01 22:24:07 UTC) #5
Primiano Tucci (use gerrit)
+dsinclair
5 years, 3 months ago (2015-09-03 08:58:09 UTC) #7
dsinclair
lgtm
5 years, 3 months ago (2015-09-03 13:40:47 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311163004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311163004/1
5 years, 3 months ago (2015-09-03 13:41:01 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/64621)
5 years, 3 months ago (2015-09-03 16:39:23 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311163004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311163004/1
5 years, 3 months ago (2015-09-03 17:44:16 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-03 18:54:16 UTC) #15
commit-bot: I haz the power
5 years, 3 months ago (2015-09-03 18:54:53 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c3e3255edf63003a1e559f50fe7f51325ce2051d
Cr-Commit-Position: refs/heads/master@{#347201}

Powered by Google App Engine
This is Rietveld 408576698