Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(754)

Issue 1311163003: Disable memcmp interceptor in ThreadSanitizer. (Closed)

Created:
5 years, 4 months ago by eugenis
Modified:
5 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable memcmp interceptor in ThreadSanitizer. The same was done for MSan last week. This is detecting real bugs that we don't have time to fix. BUG=523384, 523428 TBR=hans@chromium.org NOTRY=true Committed: https://crrev.com/778714327250971065e6b5687057925e75518d44 Cr-Commit-Position: refs/heads/master@{#345126}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/sanitizers/sanitizer_options.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
eugenis
5 years, 4 months ago (2015-08-24 18:19:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311163003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311163003/1
5 years, 4 months ago (2015-08-24 18:19:50 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-24 18:25:26 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/778714327250971065e6b5687057925e75518d44 Cr-Commit-Position: refs/heads/master@{#345126}
5 years, 4 months ago (2015-08-24 18:26:23 UTC) #6
hans
lgtm
5 years, 4 months ago (2015-08-24 18:30:47 UTC) #7
kcc1
5 years, 4 months ago (2015-08-24 18:54:49 UTC) #8
Message was sent while issue was closed.
On 2015/08/24 18:30:47, hans wrote:
> lgtm

Do you have to disable memcmp completely? 
It was on by default in tsan before my change, just not in the strict mode. 
So, maybe strict_memcmp=0?

Powered by Google App Engine
This is Rietveld 408576698