[es6] Correct length for functions with default parameters

[es6] Correct length for functions with default parameters

R=adamk@chromium.org
BUG=v8:2160
LOG=N

Committed: https://crrev.com/0b3b72671e62234dffd75c909fcb77c8bd60c7fc
Cr-Commit-Position: refs/heads/master@{#30361}

[adamk, 2015-08-24 17:51:01]

https://codereview.chromium.org/1311163002/diff/1/src/scopes.h
File src/scopes.h (right):

https://codereview.chromium.org/1311163002/diff/1/src/scopes.h#newcode133
src/scopes.h:133: bool is_optional, bool is_rest, bool* is_duplicate);
Two bools in a row suggests to me that an enum would be better.

Given that is_optional and is_rest are mutually exclusive, they could even be
part of the same enum, e.g.:

enum class ParameterType {
  kNormal,
  kOptional,
  kRest
};

I realize that there's only a single caller, though, so another option would be
to simply name the is_optional variable passed in the caller.

[rossberg, 2015-08-25 08:27:45]

https://codereview.chromium.org/1311163002/diff/1/src/scopes.h
File src/scopes.h (right):

https://codereview.chromium.org/1311163002/diff/1/src/scopes.h#newcode133
src/scopes.h:133: bool is_optional, bool is_rest, bool* is_duplicate);
On 2015/08/24 17:51:00, adamk wrote:
> Two bools in a row suggests to me that an enum would be better.
> 
> Given that is_optional and is_rest are mutually exclusive, they could even be
> part of the same enum, e.g.:
> 
> enum class ParameterType {
>   kNormal,
>   kOptional,
>   kRest
> };
> 
> I realize that there's only a single caller, though, so another option would
be
> to simply name the is_optional variable passed in the caller.

Named it at call site.

[rossberg, 2015-08-25 08:29:03]

Patchset #2 (id:20001) has been deleted

[adamk, 2015-08-25 18:25:50]

The CQ bit was checked by adamk@chromium.org

[adamk, 2015-08-25 18:25:50]

lgtm

[commit-bot: I haz the power, 2015-08-25 18:26:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1311163002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1311163002/40001

[commit-bot: I haz the power, 2015-08-25 18:52:03]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2015-08-25 18:52:22]

Patchset 2 (id:??) landed as
https://crrev.com/0b3b72671e62234dffd75c909fcb77c8bd60c7fc
Cr-Commit-Position: refs/heads/master@{#30361}