Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 1311133008: Revert of Move GN grit scripts out of secondary tree. (Closed)

Created:
5 years, 3 months ago by brettw
Modified:
5 years, 3 months ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Move GN grit scripts out of secondary tree. (patchset #1 id:1 of https://codereview.chromium.org/1317013002/ ) Reason for revert: Apparently this was incorrect. Original issue's description: > Move GN grit scripts out of secondary tree. > > These build files were in the secondary tree because I thought tools/grit was DEPSed in. However, this directory is in the Chrome tree. The DEPSed-in directory is tools/grit/grit. Moving these files to the expected place will make things more clear. > > Committed: https://crrev.com/82d10f697a4268dd9ae0fffd8f3dfb1fb42901e5 > Cr-Commit-Position: refs/heads/master@{#345713} TBR=thakis@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/30327bc319a006e6c89a7b3cdf1fef86f05ec692 Cr-Commit-Position: refs/heads/master@{#345926}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+611 lines, -611 lines) Patch
A build/secondary/tools/grit/BUILD.gn View 1 chunk +27 lines, -0 lines 0 comments Download
A build/secondary/tools/grit/grit_rule.gni View 1 chunk +482 lines, -0 lines 0 comments Download
A build/secondary/tools/grit/repack.gni View 1 chunk +47 lines, -0 lines 0 comments Download
A build/secondary/tools/grit/stamp_grit_sources.py View 1 chunk +55 lines, -0 lines 0 comments Download
D tools/grit/BUILD.gn View 1 chunk +0 lines, -27 lines 0 comments Download
D tools/grit/grit_rule.gni View 1 chunk +0 lines, -482 lines 0 comments Download
D tools/grit/repack.gni View 1 chunk +0 lines, -47 lines 0 comments Download
D tools/grit/stamp_grit_sources.py View 1 chunk +0 lines, -55 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
brettw
Created Revert of Move GN grit scripts out of secondary tree.
5 years, 3 months ago (2015-08-27 18:16:09 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311133008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311133008/1
5 years, 3 months ago (2015-08-27 18:16:25 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-08-27 18:17:39 UTC) #3
commit-bot: I haz the power
5 years, 3 months ago (2015-08-27 18:18:15 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/30327bc319a006e6c89a7b3cdf1fef86f05ec692
Cr-Commit-Position: refs/heads/master@{#345926}

Powered by Google App Engine
This is Rietveld 408576698