LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-removed.html - Issue 131113003: Fix DOMWindow::isCurrentlyDisplayedInFrame to return false when detached

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-removed.html

Issue 131113003: Fix DOMWindow::isCurrentlyDisplayedInFrame to return false when detached (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Fix ScreenOrientation + test window.open. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <html>

	2 <head>

	3 <script src="../../../resources/js-test.js"></script>

	4 <script src="resources/window-property-collector.js"></script>

	5 <script>

	6 var childWindow;

	7 var propertiesToVerify = [];

	8

	9 function insertExpectedResult(path, expected)

	10 {

	11 if (path.length < 2)

	12 return;

	13 var propertyDir = path.slice(0, -1).join('.');

	14 var cachedPropertyDir = "cached_" + propertyDir.replace('.', '_');

	15 window[cachedPropertyDir] = eval("childWindow." + propertyDir);

	16 propertiesToVerify.push({

	17 'property': ["window", cachedPropertyDir, path[path.length - 1]].join(". "),

	18 'expected': expected,

	19 });

	20 }

	21

	22 function runTest()

	23 {

	24 description("Tests access of cached DOMWindow properties after the associate d frame is no longer in a web page. Test should not crash and properties should be set to sane defaults.");

	25 var frame = document.getElementById("frame");

	26 childWindow = frame.contentWindow;

	27 collectProperties();

	28 frame.parentNode.removeChild(frame);

	29 for (var i = 0; i < propertiesToVerify.length; ++i)

	30 shouldBe(propertiesToVerify[i].property, propertiesToVerify[i].expected) ;

	31 }

	32 </script>

	33 </head>

	34 <body>

	35 <iframe id="frame" src="about:blank" onload="runTest()"></iframe>

	36 </body>

	37 </html>

OLD	NEW