LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-navigated.html - Issue 131113003: Fix DOMWindow::isCurrentlyDisplayedInFrame to return false when detached

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-navigated.html

Issue 131113003: Fix DOMWindow::isCurrentlyDisplayedInFrame to return false when detached (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Fix ScreenOrientation + test window.open. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <html>

	2 <head>

	3 <script src="../../../resources/js-test.js"></script>

	4 <script src="resources/window-property-collector.js"></script>

	5 <script>

	6 var jsTestIsAsync = true;

	7

	8 var childWindow;

	9 var propertiesToVerify = [];

	10

	11 function insertExpectedResult(path, expected)

	12 {

	13 if (path.length < 2)

	14 return;

	15 var propertyDir = path.slice(0, -1).join('.');

	16 var cachedPropertyDir = "cached_" + propertyDir.replace('.', '_');

	17 window[cachedPropertyDir] = eval("childWindow." + propertyDir);

	18 propertiesToVerify.push({

	19 'property': ["window", cachedPropertyDir, path[path.length - 1]].join(". "),

	20 'expected': expected,

	21 });

	22 }

	23

	24 function runTest()

	25 {

	26 var frame = document.getElementById("frame");

	27 if (frame.src != 'about:blank') {

	28 description("Tests access of cached DOMWindow properties after the assoc iated frame is navigated. Test should not crash and properties should be set to sane defaults.");

	29 childWindow = frame.contentWindow;

	30 collectProperties();

	31 frame.src = 'about:blank';

	32 return;

	33 }

	34 for (var i = 0; i < propertiesToVerify.length; ++i)

	35 shouldBe(propertiesToVerify[i].property, propertiesToVerify[i].expected) ;

	36 finishJSTest();

	37 }

	38 </script>

	39 </head>

	40 <body>

	41 <iframe id="frame" src="resources/blank.html" onload="runTest()"></iframe>

	42 </body>

	43 </html>

OLD	NEW