Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 1311123005: Isolate::PrintStack: restore default verbose object printing (Closed)

Created:
5 years, 3 months ago by Jakob Kummerow
Modified:
5 years, 3 months ago
Reviewers:
ulan_google, ulan
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Isolate::PrintStack: restore default verbose object printing Committed: https://crrev.com/842928afdaec5d6ec2a110ba58acf421d20957a8 Cr-Commit-Position: refs/heads/master@{#30585}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/heap/heap.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/string-stream.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (5 generated)
Jakob Kummerow
As discussed.
5 years, 3 months ago (2015-09-04 09:27:00 UTC) #2
ulan_google
lgtm
5 years, 3 months ago (2015-09-04 09:27:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311123005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311123005/1
5 years, 3 months ago (2015-09-04 09:28:19 UTC) #6
Michael Achenbach
On 2015/09/04 09:28:19, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
5 years, 3 months ago (2015-09-04 10:53:43 UTC) #7
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 3 months ago (2015-09-04 10:56:28 UTC) #9
ulan
lgtm
5 years, 3 months ago (2015-09-04 11:02:36 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311123005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311123005/1
5 years, 3 months ago (2015-09-04 11:03:36 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-04 11:30:07 UTC) #13
commit-bot: I haz the power
5 years, 3 months ago (2015-09-04 11:30:31 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/842928afdaec5d6ec2a110ba58acf421d20957a8
Cr-Commit-Position: refs/heads/master@{#30585}

Powered by Google App Engine
This is Rietveld 408576698