Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2772)

Unified Diff: chrome/browser/sync/test/integration/sync_test.cc

Issue 1311123003: Fix sync E2E tests due to unclosed avatar windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add TODO's Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/sync/test/DEPS ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync/test/integration/sync_test.cc
diff --git a/chrome/browser/sync/test/integration/sync_test.cc b/chrome/browser/sync/test/integration/sync_test.cc
index 1b14af9e2618a419bc42fbe3e60bd2674fb47c43..93a1590130499b3214733743c25a8239583900d4 100644
--- a/chrome/browser/sync/test/integration/sync_test.cc
+++ b/chrome/browser/sync/test/integration/sync_test.cc
@@ -44,6 +44,7 @@
#include "chrome/browser/ui/browser_finder.h"
#include "chrome/browser/ui/host_desktop.h"
#include "chrome/browser/ui/tabs/tab_strip_model.h"
+#include "chrome/browser/ui/views/profiles/profile_chooser_view.h"
#include "chrome/browser/ui/webui/signin/login_ui_service.h"
#include "chrome/browser/ui/webui/signin/login_ui_service_factory.h"
#include "chrome/common/chrome_constants.h"
@@ -577,6 +578,15 @@ bool SyncTest::SetupSync() {
LoginUIServiceFactory::GetForProfile(GetProfile(i))->
SyncConfirmationUIClosed(false /* configure_sync_first */);
}
+
+ // Upon multiple profiles sign in, the profile chooser widget stays open and
msw 2015/09/14 17:16:05 Is this comment still accurate? Isn't the trigger
+ // causes problems at test shutdown. This is a harmless command to close
+ // the widget in case it was showing.
+ // ChromeOS and mobile platforms don't have a ProfileChooserView.
+#if defined(FRAME_AVATAR_BUTTON)
+ // TODO(shadi): Remove this hack once crbug.com/527505 is fixed.
+ ProfileChooserView::Hide();
+#endif // defined(FRAME_AVATAR_BUTTON)
}
return true;
« no previous file with comments | « chrome/browser/sync/test/DEPS ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698