Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issue 1311113002: ServiceWorker: Make APIs that return ServiceWorkerRegistration coin a new JS object (1/3) (Closed)

Created:
5 years, 4 months ago by nhiroki
Modified:
5 years, 4 months ago
Reviewers:
falken
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

ServiceWorker: Make APIs that return ServiceWorkerRegistration coin a new JS object (1/3) This CL temporary disables tests to be broken by (2). (1) Blink: THIS PATCH (2) Chromium: https://codereview.chromium.org/1307133003/ (3) Blink: https://codereview.chromium.org/1311103002/ BUG=523904 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201103

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M LayoutTests/TestExpectations View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (9 generated)
nhiroki
PTAL
5 years, 4 months ago (2015-08-25 01:49:32 UTC) #2
falken
lgtm
5 years, 4 months ago (2015-08-25 03:27:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311113002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311113002/1
5 years, 4 months ago (2015-08-25 03:30:47 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/89037) ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 4 months ago (2015-08-25 03:32:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311113002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311113002/20001
5 years, 4 months ago (2015-08-25 04:08:46 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/103591)
5 years, 4 months ago (2015-08-25 04:40:15 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311113002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311113002/20001
5 years, 4 months ago (2015-08-25 04:45:34 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/103606)
5 years, 4 months ago (2015-08-25 05:12:44 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311113002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311113002/20001
5 years, 4 months ago (2015-08-25 05:15:44 UTC) #18
commit-bot: I haz the power
5 years, 4 months ago (2015-08-25 05:20:02 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201103

Powered by Google App Engine
This is Rietveld 408576698