Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Unified Diff: LayoutTests/http/tests/serviceworker/getregistration.html

Issue 1311103002: ServiceWorker: Make APIs that return ServiceWorkerRegistration coin a new JS object (3/3) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: address review comments Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/TestExpectations ('k') | LayoutTests/http/tests/serviceworker/getregistrations.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: LayoutTests/http/tests/serviceworker/getregistration.html
diff --git a/LayoutTests/http/tests/serviceworker/getregistration.html b/LayoutTests/http/tests/serviceworker/getregistration.html
index da50bb3ff5cf708e2016f57e8ae8974542e41dad..95abb5829a7c07b7846db35840b3fcb8fba950e0 100644
--- a/LayoutTests/http/tests/serviceworker/getregistration.html
+++ b/LayoutTests/http/tests/serviceworker/getregistration.html
@@ -24,8 +24,10 @@ async_test(function(t) {
return navigator.serviceWorker.getRegistration(scope);
})
.then(function(value) {
- assert_equals(value, registration,
- 'getRegistration should resolve with registration');
+ assert_registration_equals(value, registration);
+ assert_not_equals(
+ value, registration,
+ 'getRegistration should resolve to a new registration object');
service_worker_unregister_and_done(t, scope);
})
.catch(unreached_rejection(t));
@@ -42,8 +44,7 @@ async_test(function(t) {
return navigator.serviceWorker.getRegistration(documentURL);
})
.then(function(value) {
- assert_equals(value, registration,
- 'getRegistration should resolve with registration');
+ assert_registration_equals(value, registration);
service_worker_unregister_and_done(t, scope);
})
.catch(unreached_rejection(t));
« no previous file with comments | « LayoutTests/TestExpectations ('k') | LayoutTests/http/tests/serviceworker/getregistrations.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698