Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Unified Diff: LayoutTests/http/tests/serviceworker/getregistration.html

Issue 1311103002: ServiceWorker: Make APIs that return ServiceWorkerRegistration coin a new JS object (3/3) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/http/tests/serviceworker/getregistration.html
diff --git a/LayoutTests/http/tests/serviceworker/getregistration.html b/LayoutTests/http/tests/serviceworker/getregistration.html
index da50bb3ff5cf708e2016f57e8ae8974542e41dad..7dfc5c026c07289da4694fa4d8e83359af865482 100644
--- a/LayoutTests/http/tests/serviceworker/getregistration.html
+++ b/LayoutTests/http/tests/serviceworker/getregistration.html
@@ -24,8 +24,10 @@ async_test(function(t) {
return navigator.serviceWorker.getRegistration(scope);
})
.then(function(value) {
- assert_equals(value, registration,
- 'getRegistration should resolve with registration');
+ assert_registration_equals(value, registration);
+ assert_not_equals(
+ value, registration,
+ 'getRegistration should resolve to the new registration object');
falken 2015/08/25 03:28:28 the -> a
nhiroki 2015/08/25 06:28:07 Done.
service_worker_unregister_and_done(t, scope);
})
.catch(unreached_rejection(t));
@@ -42,8 +44,7 @@ async_test(function(t) {
return navigator.serviceWorker.getRegistration(documentURL);
})
.then(function(value) {
- assert_equals(value, registration,
- 'getRegistration should resolve with registration');
+ assert_registration_equals(value, registration);
service_worker_unregister_and_done(t, scope);
})
.catch(unreached_rejection(t));

Powered by Google App Engine
This is Rietveld 408576698