ServiceWorker: Make APIs that return ServiceWorkerRegistration coin a new JS object (3/3)

ServiceWorker: Make APIs that return ServiceWorkerRegistration coin a new JS object (3/3)

This CL re-enables tests and updates their expectations.

(1) Blink: https://codereview.chromium.org/1311113002/
(2) Chromium: https://codereview.chromium.org/1307133003/
(3) Blink: THIS PATCH

BUG=523904
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201113

[nhiroki, 2015-08-24 11:15:07]

Patchset #1 (id:1) has been deleted

[nhiroki, 2015-08-24 11:15:12]

Patchset #1 (id:20001) has been deleted

[falken, 2015-08-25 03:28:28]

falken@chromium.org changed reviewers:
+ falken@chromium.org

[falken, 2015-08-25 03:28:29]

lgtm

https://codereview.chromium.org/1311103002/diff/40001/LayoutTests/http/tests/...
File LayoutTests/http/tests/serviceworker/getregistration.html (right):

https://codereview.chromium.org/1311103002/diff/40001/LayoutTests/http/tests/...
LayoutTests/http/tests/serviceworker/getregistration.html:30: 'getRegistration
should resolve to the new registration object');
the -> a

https://codereview.chromium.org/1311103002/diff/40001/LayoutTests/http/tests/...
File LayoutTests/http/tests/serviceworker/multiple-register.html (right):

https://codereview.chromium.org/1311103002/diff/40001/LayoutTests/http/tests/...
LayoutTests/http/tests/serviceworker/multiple-register.html:24: 'register should
resolve to the new registration object');
(sorry for grammar nit)
"the new" -> "a new"
"the different" -> "a different"
throughout this file

I think it's "a" because there's more than one possible object, whereas in the
case of "the same" there is only one possible object.

https://codereview.chromium.org/1311103002/diff/40001/LayoutTests/http/tests/...
LayoutTests/http/tests/serviceworker/multiple-register.html:107: for (var i = 1;
i < 10; ++i) {
can you make 10 a named variable?

https://codereview.chromium.org/1311103002/diff/40001/LayoutTests/http/tests/...
File LayoutTests/http/tests/serviceworker/resources/test-helpers.js (right):

https://codereview.chromium.org/1311103002/diff/40001/LayoutTests/http/tests/...
LayoutTests/http/tests/serviceworker/resources/test-helpers.js:212:
assert_class_string(actual, "ServiceWorkerRegistration", description);
double quotes should be single quotes (and in several places in this file)

https://codereview.chromium.org/1311103002/diff/40001/LayoutTests/http/tests/...
LayoutTests/http/tests/serviceworker/resources/test-helpers.js:216: });
indent additional two spaces

https://codereview.chromium.org/1311103002/diff/40001/LayoutTests/http/tests/...
LayoutTests/http/tests/serviceworker/resources/test-helpers.js:229: });
indent additional two spaces

https://codereview.chromium.org/1311103002/diff/40001/LayoutTests/http/tests/...
File LayoutTests/http/tests/serviceworker/unregister-then-register.html (right):

https://codereview.chromium.org/1311103002/diff/40001/LayoutTests/http/tests/...
LayoutTests/http/tests/serviceworker/unregister-then-register.html:53: 'register
should resolve to the same value');
"same value" might mean JS ==, maybe same registration?

[nhiroki, 2015-08-25 06:28:08]

Thank you!

https://codereview.chromium.org/1311103002/diff/40001/LayoutTests/http/tests/...
File LayoutTests/http/tests/serviceworker/getregistration.html (right):

https://codereview.chromium.org/1311103002/diff/40001/LayoutTests/http/tests/...
LayoutTests/http/tests/serviceworker/getregistration.html:30: 'getRegistration
should resolve to the new registration object');
On 2015/08/25 03:28:28, falken wrote:
> the -> a

Done.

https://codereview.chromium.org/1311103002/diff/40001/LayoutTests/http/tests/...
File LayoutTests/http/tests/serviceworker/multiple-register.html (right):

https://codereview.chromium.org/1311103002/diff/40001/LayoutTests/http/tests/...
LayoutTests/http/tests/serviceworker/multiple-register.html:24: 'register should
resolve to the new registration object');
On 2015/08/25 03:28:29, falken wrote:
> (sorry for grammar nit)
> "the new" -> "a new"
> "the different" -> "a different"
> throughout this file
> 
> I think it's "a" because there's more than one possible object, whereas in the
> case of "the same" there is only one possible object.

Thanks! Grammar correction is really helpful :)

https://codereview.chromium.org/1311103002/diff/40001/LayoutTests/http/tests/...
LayoutTests/http/tests/serviceworker/multiple-register.html:107: for (var i = 1;
i < 10; ++i) {
On 2015/08/25 03:28:29, falken wrote:
> can you make 10 a named variable?

Done.

https://codereview.chromium.org/1311103002/diff/40001/LayoutTests/http/tests/...
File LayoutTests/http/tests/serviceworker/resources/test-helpers.js (right):

https://codereview.chromium.org/1311103002/diff/40001/LayoutTests/http/tests/...
LayoutTests/http/tests/serviceworker/resources/test-helpers.js:212:
assert_class_string(actual, "ServiceWorkerRegistration", description);
On 2015/08/25 03:28:29, falken wrote:
> double quotes should be single quotes (and in several places in this file)

Done.

https://codereview.chromium.org/1311103002/diff/40001/LayoutTests/http/tests/...
LayoutTests/http/tests/serviceworker/resources/test-helpers.js:216: });
On 2015/08/25 03:28:29, falken wrote:
> indent additional two spaces

Done.

https://codereview.chromium.org/1311103002/diff/40001/LayoutTests/http/tests/...
LayoutTests/http/tests/serviceworker/resources/test-helpers.js:229: });
On 2015/08/25 03:28:29, falken wrote:
> indent additional two spaces

Done.

https://codereview.chromium.org/1311103002/diff/40001/LayoutTests/http/tests/...
File LayoutTests/http/tests/serviceworker/unregister-then-register.html (right):

https://codereview.chromium.org/1311103002/diff/40001/LayoutTests/http/tests/...
LayoutTests/http/tests/serviceworker/unregister-then-register.html:53: 'register
should resolve to the same value');
On 2015/08/25 03:28:29, falken wrote:
> "same value" might mean JS ==, maybe same registration?

Done.

[nhiroki, 2015-08-25 07:03:21]

The CQ bit was checked by nhiroki@chromium.org

[nhiroki, 2015-08-25 07:03:22]

The patchset sent to the CQ was uploaded after l-g-t-m from falken@chromium.org
Link to the patchset: https://codereview.chromium.org/1311103002/#ps70001
(title: "address review comments")

[commit-bot: I haz the power, 2015-08-25 07:03:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1311103002/70001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1311103002/70001

[commit-bot: I haz the power, 2015-08-25 07:30:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-25 07:30:46]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[nhiroki, 2015-08-25 08:24:36]

The CQ bit was checked by nhiroki@chromium.org

[commit-bot: I haz the power, 2015-08-25 08:24:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1311103002/70001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1311103002/70001

[commit-bot: I haz the power, 2015-08-25 09:10:05]

Committed patchset #3 (id:70001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201113