Issue 131109: Add 'theme_dll' as a dependency of 'chrome_dll'....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 131109: Add 'theme_dll' as a dependency of 'chrome_dll'.... (Closed)

Created:
11 years, 6 months ago by sgk

Modified:
9 years, 5 months ago

Reviewers:
bradnelson, jam, bradn

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Add 'theme_dll' as a dependency of 'chrome_dll'. gyp DEPS roll so loadable_module targets ignore import libraries. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=18813

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -4 lines)			Patch
	M	DEPS	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	chrome/chrome.gyp	View		1 chunk	+1 line, -3 lines	0 comments	Download

Total messages: 3 (0 generated)

jam

sweet, thanks. would it make the build faster if chrome, instead of chrome_dll, depended on ...

11 years, 6 months ago (2009-06-19 17:23:36 UTC) #2

LGTM