Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 131105: Roll Skia up to r224, for a few bug fixes. (Closed)

Created:
11 years, 6 months ago by Dean McNamee
Modified:
9 years, 7 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Roll Skia up to r224, for a few bug fixes. Most importantly this fixes a spline drawing error and a possible Linux crash when failing to load a font. The rebaselines are mostly due to minor gradient changes (Skia changes r212 and r213). There was one layout test that was hitting the spline drawing bug, and the results now look correct (svg-as-background-5.html). BUG=13007, 14536

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/backgrounds/svg-as-background-2-expected.checksum View 1 chunk +1 line, -1 line 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/backgrounds/svg-as-background-2-expected.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/backgrounds/svg-as-background-5-expected.checksum View 1 chunk +1 line, -1 line 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/backgrounds/svg-as-background-5-expected.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/canvas/canvas-text-alignment-expected.checksum View 1 chunk +1 line, -1 line 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/canvas/canvas-text-alignment-expected.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/canvas/gradient-add-second-start-end-stop-expected.checksum View 1 chunk +1 line, -1 line 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/canvas/gradient-add-second-start-end-stop-expected.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/gradients/border-image-gradient-expected.checksum View 1 chunk +1 line, -1 line 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/gradients/border-image-gradient-expected.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/gradients/border-image-gradient-sides-and-corners-expected.checksum View 1 chunk +1 line, -1 line 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/gradients/border-image-gradient-sides-and-corners-expected.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/reflections/reflection-masks-expected.checksum View 1 chunk +1 line, -1 line 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/reflections/reflection-masks-expected.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/W3C-SVG-1.1/color-prop-01-b-expected.checksum View 1 chunk +1 line, -1 line 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/W3C-SVG-1.1/color-prop-01-b-expected.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/W3C-SVG-1.1/filters-color-01-b-expected.checksum View 1 chunk +1 line, -1 line 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/W3C-SVG-1.1/filters-color-01-b-expected.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.checksum View 1 chunk +1 line, -1 line 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/W3C-SVG-1.1/pservers-grad-01-b-expected.checksum View 1 chunk +1 line, -1 line 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/W3C-SVG-1.1/pservers-grad-01-b-expected.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/W3C-SVG-1.1/pservers-grad-04-b-expected.checksum View 1 chunk +1 line, -1 line 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/W3C-SVG-1.1/pservers-grad-04-b-expected.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/W3C-SVG-1.1/pservers-grad-05-b-expected.checksum View 1 chunk +1 line, -1 line 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/W3C-SVG-1.1/pservers-grad-05-b-expected.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/W3C-SVG-1.1/pservers-grad-07-b-expected.checksum View 1 chunk +1 line, -1 line 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/W3C-SVG-1.1/pservers-grad-07-b-expected.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/W3C-SVG-1.1/pservers-grad-09-b-expected.checksum View 1 chunk +1 line, -1 line 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/W3C-SVG-1.1/pservers-grad-09-b-expected.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/W3C-SVG-1.1/pservers-grad-10-b-expected.checksum View 1 chunk +1 line, -1 line 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/W3C-SVG-1.1/pservers-grad-10-b-expected.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.checksum View 1 chunk +1 line, -1 line 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/W3C-SVG-1.1/pservers-grad-15-b-expected.checksum View 1 chunk +1 line, -1 line 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/W3C-SVG-1.1/pservers-grad-15-b-expected.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/W3C-SVG-1.1/pservers-grad-16-b-expected.checksum View 1 chunk +1 line, -1 line 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/W3C-SVG-1.1/pservers-grad-16-b-expected.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/W3C-SVG-1.1/pservers-grad-17-b-expected.checksum View 1 chunk +1 line, -1 line 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/W3C-SVG-1.1/pservers-grad-17-b-expected.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/W3C-SVG-1.1/pservers-grad-18-b-expected.checksum View 1 chunk +1 line, -1 line 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/W3C-SVG-1.1/pservers-grad-18-b-expected.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/W3C-SVG-1.1/pservers-grad-19-b-expected.checksum View 1 chunk +1 line, -1 line 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/W3C-SVG-1.1/pservers-grad-19-b-expected.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/batik/paints/gradientLimit-expected.checksum View 1 chunk +1 line, -1 line 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/batik/paints/gradientLimit-expected.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/carto.net/colourpicker-expected.checksum View 1 chunk +1 line, -1 line 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/carto.net/colourpicker-expected.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/custom/deep-dynamic-updates-expected.checksum View 1 chunk +1 line, -1 line 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/custom/deep-dynamic-updates-expected.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/custom/dominant-baseline-hanging-expected.checksum View 1 chunk +1 line, -1 line 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/custom/dominant-baseline-hanging-expected.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/custom/feComponentTransfer-Discrete-expected.checksum View 1 chunk +1 line, -1 line 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/custom/feComponentTransfer-Discrete-expected.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/custom/feComponentTransfer-Gamma-expected.checksum View 1 chunk +1 line, -1 line 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/custom/feComponentTransfer-Gamma-expected.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/custom/feComponentTransfer-Linear-expected.checksum View 1 chunk +1 line, -1 line 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/custom/feComponentTransfer-Linear-expected.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/custom/feComponentTransfer-Table-expected.checksum View 1 chunk +1 line, -1 line 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/custom/feComponentTransfer-Table-expected.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/custom/gradient-deep-referencing-expected.checksum View 1 chunk +1 line, -1 line 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/custom/gradient-deep-referencing-expected.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/custom/gradient-rotated-bbox-expected.checksum View 1 chunk +1 line, -1 line 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/custom/gradient-rotated-bbox-expected.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/custom/gradient-stop-corner-cases-expected.checksum View 1 chunk +1 line, -1 line 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/custom/gradient-stop-corner-cases-expected.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/custom/gradient-stroke-width-expected.checksum View 1 chunk +1 line, -1 line 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/custom/gradient-stroke-width-expected.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/custom/grayscale-gradient-mask-expected.checksum View 1 chunk +1 line, -1 line 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/custom/grayscale-gradient-mask-expected.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/custom/group-opacity-expected.checksum View 1 chunk +1 line, -1 line 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/custom/group-opacity-expected.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/custom/inline-svg-in-xhtml-expected.checksum View 1 chunk +1 line, -1 line 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/custom/inline-svg-in-xhtml-expected.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/custom/js-late-gradient-and-object-creation-expected.checksum View 1 chunk +1 line, -1 line 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/custom/js-late-gradient-and-object-creation-expected.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/custom/js-late-gradient-creation-expected.checksum View 1 chunk +1 line, -1 line 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/custom/js-late-gradient-creation-expected.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/custom/js-update-gradient-expected.checksum View 1 chunk +1 line, -1 line 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/custom/js-update-gradient-expected.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/custom/js-update-stop-expected.checksum View 1 chunk +1 line, -1 line 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/custom/js-update-stop-expected.png View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Dean McNamee
I manually inspected each one of the layout test differences. There is something crazy going ...
11 years, 6 months ago (2009-06-19 12:25:02 UTC) #1
M-A Ruel
11 years, 6 months ago (2009-06-20 00:33:09 UTC) #2 
rubberstamp lgtm

Powered by Google App Engine
This is Rietveld 408576698